linux-kernel - Re: [PATCH v2 3/4] dt-bindings: clock: Add device tree bindings for vmclock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36d33acb-7436-4f86-848e-ea280efc05a9@kernel.org>
Date: Wed, 3 Dec 2025 08:25:40 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Chalios, Babis" <bchalios@...zon.es>,
 "richardcochran@...il.com" <richardcochran@...il.com>,
 "dwmw2@...radead.org" <dwmw2@...radead.org>,
 "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
 "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>,
 "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com"
 <pabeni@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc: "Graf (AWS), Alexander" <graf@...zon.de>,
 "mzxreary@...inter.de" <mzxreary@...inter.de>,
 "Woodhouse, David" <dwmw@...zon.co.uk>
Subject: Re: [PATCH v2 3/4] dt-bindings: clock: Add device tree bindings for
 vmclock

On 03/12/2025 08:22, Krzysztof Kozlowski wrote:
> On 02/12/2025 21:11, Chalios, Babis wrote:
>> From: David Woodhouse <dwmw@...zon.co.uk>
>>
>> Add device tree bindings for the vmclock device, similar to the existing
>> vmgenid bindings. The vmclock device provides a PTP clock source and
>> precise timekeeping across live migration and snapshot/restore operations.
>>
>> The bindings specify a required memory region containing the vmclock_abi
>> structure and an optional interrupt for clock disruption notifications.
>>
>> Signed-off-by: David Woodhouse <dwmw@...zon.co.uk>
>> Signed-off-by: Babis Chalios <bchalios@...zon.es>
> 
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
> 
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
> 
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time.
> 
> Please kindly resend and include all necessary To/Cc entries.

I am not reviewing patches not bothering to cc maintainers, but to spare
you from obvious resubmits of v4:

A nit, subject: drop second/last, redundant "device tree bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
(you could not make more redundant subject...)

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).


Best regards,
Krzysztof