linux-kernel - Re: [PATCH v2 1/1] scsi: core: Fix error handler encryption support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aS_pE4nf7wQ031Y8@infradead.org>
Date: Tue, 2 Dec 2025 23:38:59 -0800
From: Christoph Hellwig <hch@...radead.org>
To: Po-Wen Kao <powenkao@...gle.com>, Hannes Reinecke <hare@...e.com>
Cc: "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	"open list:SCSI SUBSYSTEM" <linux-scsi@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] scsi: core: Fix error handler encryption support

On Wed, Dec 03, 2025 at 07:33:08AM +0000, Po-Wen Kao wrote:
> From: Brian Kao <powenkao@...gle.com>
> 
> Some low-level drivers (LLD) access block layer crypto fields, such as
> rq->crypt_keyslot and rq->crypt_ctx within `struct request`, to
> configure hardware for inline encryption.

So don't do that except for commands that can actually be encrypted,
i.e. those that have non-zero payload size.  I think you really want
to fix this in the driver.

And we really need to stop passing scsi_cmnds to the error handler.

Hannes, any chance you could send another batch of your decades old
series?