linux-kernel - Re: [PATCH net-next v8 2/3] net: ti: icssm-prueth: Add switchdev support for icssm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <483862293.84606.1764751079970.JavaMail.zimbra@couthit.local>
Date: Wed, 3 Dec 2025 14:07:59 +0530 (IST)
From: Parvathi Pudi <parvathi@...thit.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Parvathi Pudi <parvathi@...thit.com>, andrew+netdev <andrew+netdev@...n.ch>, 
	davem <davem@...emloft.net>, edumazet <edumazet@...gle.com>, 
	pabeni <pabeni@...hat.com>, rogerq <rogerq@...nel.org>, 
	pmohan <pmohan@...thit.com>, basharath <basharath@...thit.com>, 
	afd <afd@...com>, linux-kernel <linux-kernel@...r.kernel.org>, 
	netdev <netdev@...r.kernel.org>, 
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, 
	ALOK TIWARI <alok.a.tiwari@...cle.com>, horms <horms@...nel.org>, 
	pratheesh <pratheesh@...com>, j-rameshbabu <j-rameshbabu@...com>, 
	Vignesh Raghavendra <vigneshr@...com>, praneeth <praneeth@...com>, 
	srk <srk@...com>, rogerq <rogerq@...com>, 
	krishna <krishna@...thit.com>, mohan <mohan@...thit.com>, 
	danishanwar <danishanwar@...com>
Subject: Re: [PATCH net-next v8 2/3] net: ti: icssm-prueth: Add switchdev
 support for icssm_prueth driver

Hi,

> On Wed, 26 Nov 2025 21:57:13 +0530 Parvathi Pudi wrote:
>> + */
>> +static void icssm_prueth_sw_switchdev_event_work(struct work_struct *work)
>> +{
>> +	struct icssm_prueth_sw_switchdev_event_work *switchdev_work =
>> +		container_of(work,
>> +			     struct icssm_prueth_sw_switchdev_event_work, work);
> 
> Consider using shorter type names.
> 

We will address this in the next version.

>> +	struct prueth_emac *emac = switchdev_work->emac;
>> +	struct switchdev_notifier_fdb_info *fdb;
>> +	struct prueth *prueth = emac->prueth;
>> +	int port = emac->port_id;
>> +
>> +	rtnl_lock();
>> +
>> +	/* Interface is not up */
>> +	if (!emac->prueth->fdb_tbl) {
>> +		rtnl_unlock();
> 
> Are you not leaking the device reference here?
> 

We will address this in the next version.

Thanks and Regards,
Parvathi.