[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aS_8ndgdVbffPYGN@gourry-fedora-PF4VCD3F>
Date: Wed, 3 Dec 2025 04:02:21 -0500
From: Gregory Price <gourry@...rry.net>
To: "David Hildenbrand (Red Hat)" <david@...nel.org>
Cc: Michal Hocko <mhocko@...e.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Aboorva Devarajan <aboorvad@...ux.ibm.com>, vbabka@...e.cz,
surenb@...gle.com, jackmanb@...gle.com, hannes@...xchg.org,
ziy@...dia.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org,
Oscar Salvador <OSalvador@...e.com>
Subject: Re: [PATCH] mm/page_alloc: make percpu_pagelist_high_fraction reads
lock-free
On Wed, Dec 03, 2025 at 09:51:52AM +0100, David Hildenbrand (Red Hat) wrote:
> On 12/3/25 09:42, Michal Hocko wrote:
> > > if (!ret) {
> > > /*
> > > * TODO: fatal migration failures should bail
> > > * out
> > > */
> > > do_migrate_range(pfn, end_pfn);
> > > }
> > > ...
> > >
> > > Maybe it's time to implement the bail out?
> >
> > That would be great but can we tell transient from permanent migration
> > failures? Maybe long term pins could be treated as permanent failure.
>
> Did we try offline a ZONE_MOVABLE block or a ZONE_NORMAL block? In case of
> ZONE_MOABLE, bailing out is not really the right thing to do.
>
My transient failure (although i'm not sure it was actually transient, i
killed it and retried after a few minutes and it succeeded immediately)
was on a ZONE_MOVABLE block.
Kind of suggested to me there was some bad condition the resolved once I
took a second to release the lock and try again.
Can't speak for Aboorva's situation.
~Gregory
Powered by blists - more mailing lists