linux-kernel - Re: [PATCH] thermal: sprd: Fix raw temperature clamping in sprd_thm_rawdata_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <587213a8-9332-4384-b26b-21f55d8b480b@linux.alibaba.com>
Date: Wed, 3 Dec 2025 09:37:28 +0800
From: Baolin Wang <baolin.wang@...ux.alibaba.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>,
 Lukasz Luba <lukasz.luba@....com>, Orson Zhai <orsonzhai@...il.com>,
 Chunyan Zhang <zhang.lyra@...il.com>, Freeman Liu <freeman.liu@...soc.com>
Cc: stable@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal: sprd: Fix raw temperature clamping in
 sprd_thm_rawdata_to_temp

On 2025/12/2 19:46, Thorsten Blum wrote:
> The raw temperature data was never clamped to SPRD_THM_RAW_DATA_LOW or
> SPRD_THM_RAW_DATA_HIGH because the return value of clamp() was not used.
> Fix this by assigning the clamped value to 'rawdata'.
> 
> Casting SPRD_THM_RAW_DATA_LOW and SPRD_THM_RAW_DATA_HIGH to u32 is also
> redundant and can be removed.
> 
> Cc: stable@...r.kernel.org
> Fixes: 554fdbaf19b1 ("thermal: sprd: Add Spreadtrum thermal driver support")
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>   drivers/thermal/sprd_thermal.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c
> index e546067c9621..f7fa83b2428e 100644
> --- a/drivers/thermal/sprd_thermal.c
> +++ b/drivers/thermal/sprd_thermal.c
> @@ -178,7 +178,7 @@ static int sprd_thm_sensor_calibration(struct device_node *np,
>   static int sprd_thm_rawdata_to_temp(struct sprd_thermal_sensor *sen,
>   				    u32 rawdata)
>   {
> -	clamp(rawdata, (u32)SPRD_THM_RAW_DATA_LOW, (u32)SPRD_THM_RAW_DATA_HIGH);
> +	rawdata = clamp(rawdata, SPRD_THM_RAW_DATA_LOW, SPRD_THM_RAW_DATA_HIGH);
>   
>   	/*
>   	 * According to the thermal datasheet, the formula of converting

Ah, good catch. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>