linux-kernel - Re: [PATCH v1 29/31] serial: 8250_mxpcie: Add sysfs to control terminator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfXSJFN9Ev8_bChvMuxP5T+u2wgd=3=aQnvjkHaNCF_ew@mail.gmail.com>
Date: Wed, 3 Dec 2025 11:21:29 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Crescent Hsieh <crescentcy.hsieh@...a.com>
Cc: gregkh@...uxfoundation.org, jirislaby@...nel.org, 
	ilpo.jarvinen@...ux.intel.com, linux-kernel@...r.kernel.org, 
	linux-serial@...r.kernel.org
Subject: Re: [PATCH v1 29/31] serial: 8250_mxpcie: Add sysfs to control terminator

On Wed, Dec 3, 2025 at 4:55 AM Crescent Hsieh <crescentcy.hsieh@...a.com> wrote:
> On Mon, Dec 01, 2025 at 04:40:51AM +0200, Andy Shevchenko wrote:
> > On Sun, Nov 30, 2025 at 12:46 PM Crescent Hsieh
> > <crescentcy.hsieh@...a.com> wrote:

...

> > > Example usage:
> > >
> > >     # Enable terminator on ttyS*
> > >     echo 1 > /sys/class/tty/ttyS*/mxpcie8250_terminator
> > >
> > >     # Check current state
> > >     cat /sys/class/tty/ttyS*/mxpcie8250_terminator
> > >     enabled
> >
> > This introduces an ABI without documentation update. It's no go.
>
> Just to confirm my understanding — for any new user-visible ABI such
> as a sysfs attribute, the corresponding documentation under
> Documentation/ABI/ must be included in the same patch/series?

Yes.

-- 
With Best Regards,
Andy Shevchenko