linux-kernel - Re: [PATCH] thermal: sprd: Fix temperature clamping in sprd_thm_temp_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <426fda8e-44f7-44a3-9bc8-97abbf000f21@linux.alibaba.com>
Date: Wed, 3 Dec 2025 09:38:43 +0800
From: Baolin Wang <baolin.wang@...ux.alibaba.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>,
 Lukasz Luba <lukasz.luba@....com>, Orson Zhai <orsonzhai@...il.com>,
 Chunyan Zhang <zhang.lyra@...il.com>, Freeman Liu <freeman.liu@...soc.com>
Cc: stable@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal: sprd: Fix temperature clamping in
 sprd_thm_temp_to_rawdata

On 2025/12/2 19:47, Thorsten Blum wrote:
> The temperature was never clamped to SPRD_THM_TEMP_LOW or
> SPRD_THM_TEMP_HIGH because the return value of clamp() was not used. Fix
> this by assigning the clamped value to 'temp'.
> 
> Casting SPRD_THM_TEMP_LOW and SPRD_THM_TEMP_HIGH to int is also
> redundant and can be removed.
> 
> Cc: stable@...r.kernel.org
> Fixes: 554fdbaf19b1 ("thermal: sprd: Add Spreadtrum thermal driver support")
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>   drivers/thermal/sprd_thermal.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c
> index f7fa83b2428e..44fa45f74da7 100644
> --- a/drivers/thermal/sprd_thermal.c
> +++ b/drivers/thermal/sprd_thermal.c
> @@ -192,7 +192,7 @@ static int sprd_thm_temp_to_rawdata(int temp, struct sprd_thermal_sensor *sen)
>   {
>   	u32 val;
>   
> -	clamp(temp, (int)SPRD_THM_TEMP_LOW, (int)SPRD_THM_TEMP_HIGH);
> +	temp = clamp(temp, SPRD_THM_TEMP_LOW, SPRD_THM_TEMP_HIGH);
>   
>   	/*
>   	 * According to the thermal datasheet, the formula of converting

Good catch. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>