linux-kernel - Re: [PATCH v2] platform/x86: asus-wmi: use brightness_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <176475524451.7250.10247983674416836381.b4-ty@linux.intel.com>
Date: Wed, 03 Dec 2025 11:47:24 +0200
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Corentin Chary <corentin.chary@...il.com>, 
 "Luke D. Jones" <luke@...nes.dev>, Denis Benato <benato.denis96@...il.com>, 
 Hans de Goede <hansg@...nel.org>, 
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
 Jian-Hong Pan <jian-hong@...lessm.com>, Anton Khirnov <anton@...rnov.net>
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] platform/x86: asus-wmi: use
 brightness_set_blocking() for kbd led

On Sat, 29 Nov 2025 11:13:08 +0100, Anton Khirnov wrote:

> kbd_led_set() can sleep, and so may not be used as the brightness_set()
> callback.
> 
> Otherwise using this led with a trigger leads to system hangs
> accompanied by:
> BUG: scheduling while atomic: acpi_fakekeyd/2588/0x00000003
> CPU: 4 UID: 0 PID: 2588 Comm: acpi_fakekeyd Not tainted 6.17.9+deb14-amd64 #1 PREEMPT(lazy)  Debian 6.17.9-1
> Hardware name: ASUSTeK COMPUTER INC. ASUS EXPERTBOOK B9403CVAR/B9403CVAR, BIOS B9403CVAR.311 12/24/2024
> Call Trace:
>  <TASK>
>  [...]
>  schedule_timeout+0xbd/0x100
>  __down_common+0x175/0x290
>  down_timeout+0x67/0x70
>  acpi_os_wait_semaphore+0x57/0x90
>  [...]
>  asus_wmi_evaluate_method3+0x87/0x190 [asus_wmi]
>  led_trigger_event+0x3f/0x60
>  [...]
> 
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: asus-wmi: use brightness_set_blocking() for kbd led
      commit: ccb61a328321ba3f8567e350664c9ca7a42b6c70

--
 i.