linux-kernel - Re: [PATCH] thermal: sprd: Use min instead of clamp in sprd_thm_temp_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4baf9afc-bcc5-405d-9d9b-55a988c9f43e@linux.alibaba.com>
Date: Wed, 3 Dec 2025 09:48:04 +0800
From: Baolin Wang <baolin.wang@...ux.alibaba.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>,
 Lukasz Luba <lukasz.luba@....com>, Orson Zhai <orsonzhai@...il.com>,
 Chunyan Zhang <zhang.lyra@...il.com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal: sprd: Use min instead of clamp in
 sprd_thm_temp_to_rawdata

On 2025/12/2 19:50, Thorsten Blum wrote:
> Clamping 'val' to itself is unnecessary and the expression can be
> simplified by using min() instead. Casting SPRD_THM_RAW_DATA_HIGH to u32
> is also redundant and can be removed.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>   drivers/thermal/sprd_thermal.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c
> index 44fa45f74da7..d683fcb0f8ab 100644
> --- a/drivers/thermal/sprd_thermal.c
> +++ b/drivers/thermal/sprd_thermal.c
> @@ -201,7 +201,7 @@ static int sprd_thm_temp_to_rawdata(int temp, struct sprd_thermal_sensor *sen)
>   	 */
>   	val = (temp + sen->cal_offset) / sen->cal_slope;
>   
> -	return clamp(val, val, (u32)(SPRD_THM_RAW_DATA_HIGH - 1));
> +	return min(val, SPRD_THM_RAW_DATA_HIGH - 1);
>   }
>   
>   static int sprd_thm_read_temp(struct thermal_zone_device *tz, int *temp)

LGTM. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>