linux-kernel - Re: [PATCH] fbdev/pxafb: Fix multiple clamped values in pxafb_adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTAHkxg1_LDzZNSb@smile.fi.intel.com>
Date: Wed, 3 Dec 2025 11:49:07 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Helge Deller <deller@....de>
Cc: Thorsten Blum <thorsten.blum@...ux.dev>,
	Chelsy Ratnawat <chelsyratnawat2001@...il.com>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	Raag Jadav <raag.jadav@...el.com>, linux-fbdev@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fbdev/pxafb: Fix multiple clamped values in
 pxafb_adjust_timing

On Tue, Dec 02, 2025 at 08:36:08PM +0100, Helge Deller wrote:
> On 12/2/25 19:36, Thorsten Blum wrote:
> > On 2. Dec 2025, at 19:28, Helge Deller wrote:
> > > On 12/2/25 19:15, Thorsten Blum wrote:

...

> > > How did you notice? Do you actually have the hardware and tested it?
> > 
> > I only compile-tested it.
> > 
> > I stumbled upon another driver with the same bug and then used grep to
> > search for other instances and found about 6 or 7, including this one.
> 
> Ok. But this then means, maybe the clamping isn't needed (since nobody complained),
> or that nobody noticed because nobody uses the driver any longer.

I think it's a combination of factors: 1) rarely people have this hardware,
especially nowadays, to run more or less new kernel; 2) there are no conditions
happened that this patch fixes in their environments; 3) something else I
missed.


-- 
With Best Regards,
Andy Shevchenko