linux-kernel - Re: [PATCH] spi: cadence-quadspi: Fix clock enable underflows due to runtime PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e95bb125-6b73-4991-acce-a964854da0a1@sirena.org.uk>
Date: Wed, 3 Dec 2025 11:58:30 +0000
From: Mark Brown <broonie@...nel.org>
To: Siddharth Vadapalli <s-vadapalli@...com>
Cc: Francesco Dolcini <francesco@...cini.it>, Anurag Dutta <a-dutta@...com>,
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] spi: cadence-quadspi: Fix clock enable underflows due to
 runtime PM

On Wed, Dec 03, 2025 at 04:12:04PM +0530, Siddharth Vadapalli wrote:
> On Tue, 2025-12-02 at 22:53 +0000, Mark Brown wrote:

> > Avoid this confused ownership by moving the pm_runtime_get_noresume() to
> > after the last point at which the probe() function can fail.

> Thank you for the patch. The 'clock already disabled' issue persists on
> J721E SoC with the patch applied:

Do you mean it reappears rather than persists?  

> https://gist.github.com/Siddharth-Vadapalli-at-TI/a664f59366ad681856b862d621487b7f

Interesting, I can't see any logging that indicates we should be
reaching the error handling paths in that log...

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)