linux-kernel - Re: [PATCH 1/2] ASoc: qcom: q6afe: fix bad guard conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1533a073-6605-4995-bad1-c35ff367aa60@oss.qualcomm.com>
Date: Wed, 3 Dec 2025 14:11:37 +0000
From: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
To: Johan Hovold <johan@...nel.org>, Srinivas Kandagatla <srini@...nel.org>,
        Mark Brown <broonie@...nel.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, linux-sound@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ASoc: qcom: q6afe: fix bad guard conversion

On 12/3/25 10:55 AM, Johan Hovold wrote:
> A recent spinlock guard conversion used the wrong guard so that
> interrupts are no longer disabled while holding the port list lock.
> 
> Based on a cursory look this appears to be safe currently, but it could
> cause a deadlock if one of these helpers are ever called in interrupt
> context.
> 
> Fixes: 4b1edbb028fb ("ASoC: qcom: q6afe: Use guard() for spin locks")
> Cc: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---

Thanks Johan, That is true, I missed the irqsave variant .


Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>

--srini>  sound/soc/qcom/qdsp6/q6afe.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6/q6afe.c
> index 980851a12976..0b01fc9e13a7 100644
> --- a/sound/soc/qcom/qdsp6/q6afe.c
> +++ b/sound/soc/qcom/qdsp6/q6afe.c
> @@ -947,7 +947,7 @@ static struct q6afe_port *q6afe_find_port(struct q6afe *afe, int token)
>  	struct q6afe_port *p;
>  	struct q6afe_port *ret = NULL;
>  
> -	guard(spinlock)(&afe->port_list_lock);
> +	guard(spinlock_irqsave)(&afe->port_list_lock);
>  	list_for_each_entry(p, &afe->port_list, node)
>  		if (p->token == token) {
>  			ret = p;
> @@ -1807,7 +1807,7 @@ struct q6afe_port *q6afe_port_get_from_id(struct device *dev, int id)
>  	port->cfg_type = cfg_type;
>  	kref_init(&port->refcount);
>  
> -	guard(spinlock)(&afe->port_list_lock);
> +	guard(spinlock_irqsave)(&afe->port_list_lock);
>  	list_add_tail(&port->node, &afe->port_list);
>  
>  	return port;