linux-kernel - Re: [PATCH] scsi: ufs: core: Fix link error when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <98ac8e0b-6027-4f6d-b5cf-b9ad9c856ecf@app.fastmail.com>
Date: Wed, 03 Dec 2025 15:39:04 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "kernel test robot" <lkp@...el.com>, "Bean Huo" <beanhuo@...pp.de>,
 avri.altman@...disk.com, "Bart Van Assche" <bvanassche@....org>,
 "Alim Akhtar" <alim.akhtar@...sung.com>,
 "James E.J. Bottomley" <jejb@...ux.ibm.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>, can.guo@....qualcomm.com,
 "Bean Huo" <beanhuo@...ron.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
 linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: ufs: core: Fix link error when CONFIG_RPMB=m

On Wed, Dec 3, 2025, at 07:15, kernel test robot wrote:
>
> All errors (new ones prefixed by >>):
>
>>> drivers/ufs/core/ufs-rpmb.c:135:5: error: redefinition of 'ufs_rpmb_probe'
>      135 | int ufs_rpmb_probe(struct ufs_hba *hba)
>          |     ^
>    drivers/ufs/core/ufshcd-priv.h:445:19: note: previous definition is here
>      445 | static inline int ufs_rpmb_probe(struct ufs_hba *hba)
>          |                   ^
>>> drivers/ufs/core/ufs-rpmb.c:234:6: error: redefinition of 'ufs_rpmb_remove'

The declaration and definitio are inconsistent: the former is inside of
an #ifdef block, the latter is not. I think either way works, but it
needs to be the same for both.

     Arnd