linux-kernel - Re: [PATCH v2] gpio: regmap: Fix memleak in gpio_remap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTBOSfH9KyI0epZB@smile.fi.intel.com>
Date: Wed, 3 Dec 2025 16:50:49 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Wentao Guan <guanwentao@...ontech.com>
Cc: brgl@...nel.org, mathieu.dubois-briand@...tlin.com,
	ioana.ciornei@....com, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, zhanjun@...ontech.com,
	niecheng1@...ontech.com, stable@...r.kernel.org,
	WangYuli <wangyl5933@...naunicom.cn>
Subject: Re: [PATCH v2] gpio: regmap: Fix memleak in gpio_remap_register

On Wed, Dec 03, 2025 at 10:15:58PM +0800, Wentao Guan wrote:
> We should call gpiochip_remove(chip) to free the resource
> alloced by gpiochip_add_data(chip, gpio) after the err path.

> Fixes: 553b75d4bfe9 ("gpio: regmap: Allow to allocate regmap-irq device")

As I told in v1, add the other Fixes tag, to show that the code was modified
and this change has a dependency to that.

...

With that done, it LGTM.

-- 
With Best Regards,
Andy Shevchenko