[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <q42ky23vrxcyaefudecra3otbcq27kekmrwbjrtqmwsloqwuom@o6xw37uul4e7>
Date: Wed, 3 Dec 2025 09:20:31 -0800
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Ingo Molnar <mingo@...nel.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
linux-kernel@...r.kernel.org, linux-tip-commits@...r.kernel.org, x86@...nel.org
Subject: Re: [tip: objtool/urgent] objtool: Consolidate annotation macros
On Wed, Dec 03, 2025 at 05:57:00PM +0100, Ingo Molnar wrote:
> * Linus Torvalds <torvalds@...ux-foundation.org> wrote:
>
> > On Wed, 3 Dec 2025 at 08:40, tip-bot2 for Josh Poimboeuf
> > <tip-bot2@...utronix.de> wrote:
> > >
> > > Consolidate __ASM_ANNOTATE into a single macro which is used by both C
> > > and asm. This also makes the code generation a bit more palatable by
> > > putting it all on a single line.
> >
> > No objections, but I just wanted to say that when stating "this makes
> > the code generation more palatable", it would be good to actually show
> > *how* it does it (with just an example).
> >
> > Because it's hard to read that diff and figure out what the actual
> > effect is. I can just about see it, but...
>
> Sorry, should have added this to the changelog.
>
> Find below a diff of the arch/x86/kernel/process.s output
> of your tree versus current tip:objtool/urgent.
It's still not exactly "pretty", but I'm looking again at how to make
all that better... Hopefully we can get .macro working with Clang
inline asm at some point.
--
Josh
Powered by blists - more mailing lists