linux-kernel - Re: [PATCH] objtool: Fix stack overflow in validate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTBhFEoXJnFFENa6@gmail.com>
Date: Wed, 3 Dec 2025 17:11:00 +0100
From: Ingo Molnar <mingo@...nel.org>
To: Josh Poimboeuf <jpoimboe@...nel.org>
Cc: David Laight <david.laight.linux@...il.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, Nathan Chancellor <nathan@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Alexandre Chartre <alexandre.chartre@...cle.com>
Subject: Re: [PATCH] objtool: Fix stack overflow in validate_branch()


* Josh Poimboeuf <jpoimboe@...nel.org> wrote:

> Here's with reading /proc/self/maps and rlimit, it's not too bad:
> 
> From: Josh Poimboeuf <jpoimboe@...nel.org>
> Subject: [PATCH] objtool: Add signal error handling
> 
> When the kernel build fails due to an objtool seg fault, the error
> message is confusing:
> 
>   make[5]: *** [scripts/Makefile.build:503: drivers/scsi/qla2xxx/qla2xxx.o] Error 139
>   make[5]: *** Deleting file 'drivers/scsi/qla2xxx/qla2xxx.o'
>   make[4]: *** [scripts/Makefile.build:556: drivers/scsi/qla2xxx] Error 2
>   make[3]: *** [scripts/Makefile.build:556: drivers/scsi] Error 2
>   make[2]: *** [scripts/Makefile.build:556: drivers] Error 2
>   make[1]: *** [/home/jpoimboe/git/linux/Makefile:2013: .] Error 2
>   make: *** [Makefile:248: __sub-make] Error 2
> 
> Add a signal handler which prints an error message like:
> 
>   drivers/scsi/qla2xxx/qla2xxx.o: error: SIGSEGV: objtool stack overflow!
> 
> or
> 
>   drivers/scsi/qla2xxx/qla2xxx.o: error: SIGSEGV: objtool crash!
> 
> Also, re-raise the signal so the core dump still gets triggered.

Great - this version looks good to me, and I've applied it to
tip:objtool/urgent.

Thanks,

	Ingo