linux-kernel - Re: [PATCH] drm/panel: novatek-nt35560: avoid on-stack device structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=V6-14spgnDi6Lh+-jbRMtfNzdsH2F39nL_tED9AnUYsw@mail.gmail.com>
Date: Thu, 4 Dec 2025 09:33:18 -0800
From: Doug Anderson <dianders@...omium.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Linus Walleij <linusw@...nel.org>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Brigham Campbell <me@...ghamcampbell.com>, Arnd Bergmann <arnd@...db.de>, 
	Jessica Zhang <jesszhan0024@...il.com>, Anusha Srivatsa <asrivats@...hat.com>, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel: novatek-nt35560: avoid on-stack device structure

Hi,

On Thu, Dec 4, 2025 at 1:45 AM Arnd Bergmann <arnd@...nel.org> wrote:
>
> From: Arnd Bergmann <arnd@...db.de>
>
> A cleanup patch apparently by accident used a local device structure
> instead of a pointer to one in the nt35560_read_id() function, causing
> a warning about stack usage:
>
> drivers/gpu/drm/panel/panel-novatek-nt35560.c: In function 'nt35560_read_id':
> drivers/gpu/drm/panel/panel-novatek-nt35560.c:249:1: error: the frame size of 1296 bytes is larger than 1280 bytes [-Werror=frame-larger-than=]
>
> Change this to a pointer as was liley intended here.
>
> Fixes: 5fbc0dbb92d6 ("drm/panel: novatek-nt35560: Clean up driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/gpu/drm/panel/panel-novatek-nt35560.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Whoops! Not sure how I missed that in code review. Thanks for the fix!

Reviewed-by: Douglas Anderson <dianders@...omium.org>

Pushed to drm-misc-fixes:

[1/1] drm/panel: novatek-nt35560: avoid on-stack device structure
      commit: 1a7a7b80a22448dff55e1ad69a4681fd8b760b85