linux-kernel - Re: [PATCH net-next v21 01/14] dt-bindings: net: Introduce the ethernet-connector description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20251204183541.GA1936817-robh@kernel.org>
Date: Thu, 4 Dec 2025 12:35:41 -0600
From: Rob Herring <robh@...nel.org>
To: "Christophe Leroy (CS GROUP)" <chleroy@...nel.org>
Cc: Maxime Chevallier <maxime.chevallier@...tlin.com>,
	Conor Dooley <conor+dt@...nel.org>,
	Marek Behún <kabel@...nel.org>,
	Antoine Tenart <atenart@...nel.org>, mwojtas@...omium.org,
	netdev@...r.kernel.org, Daniel Golle <daniel@...rotopia.org>,
	Herve Codina <herve.codina@...tlin.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Vladimir Oltean <vladimir.oltean@....com>,
	linux-arm-msm@...r.kernel.org, thomas.petazzoni@...tlin.com,
	davem@...emloft.net, Florian Fainelli <f.fainelli@...il.com>,
	linux-kernel@...r.kernel.org,
	Romain Gantois <romain.gantois@...tlin.com>,
	devicetree@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Russell King <linux@...linux.org.uk>,
	Oleksij Rempel <o.rempel@...gutronix.de>,
	linux-arm-kernel@...ts.infradead.org,
	Heiner Kallweit <hkallweit1@...il.com>,
	Dimitri Fedrau <dimitri.fedrau@...bherr.com>,
	Nicolò Veronese <nicveronese@...il.com>,
	Tariq Toukan <tariqt@...dia.com>,
	Köry Maincent <kory.maincent@...tlin.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Andrew Lunn <andrew@...n.ch>, Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next v21 01/14] dt-bindings: net: Introduce the
 ethernet-connector description

On Sat, Nov 29, 2025 at 12:40:15PM +0100, Christophe Leroy (CS GROUP) wrote:
> 
> 
> Le 29/11/2025 à 10:21, Rob Herring (Arm) a écrit :
> > 
> > On Sat, 29 Nov 2025 09:22:13 +0100, Maxime Chevallier wrote:
> > > The ability to describe the physical ports of Ethernet devices is useful
> > > to describe multi-port devices, as well as to remove any ambiguity with
> > > regard to the nature of the port.
> > > 
> > > Moreover, describing ports allows for a better description of features
> > > that are tied to connectors, such as PoE through the PSE-PD devices.
> > > 
> > > Introduce a binding to allow describing the ports, for now with 2
> > > attributes :
> > > 
> > >   - The number of pairs, which is a quite generic property that allows
> > >     differentating between multiple similar technologies such as BaseT1
> > >     and "regular" BaseT (which usually means BaseT4).
> > > 
> > >   - The media that can be used on that port, such as BaseT for Twisted
> > >     Copper, BaseC for coax copper, BaseS/L for Fiber, BaseK for backplane
> > >     ethernet, etc. This allows defining the nature of the port, and
> > >     therefore avoids the need for vendor-specific properties such as
> > >     "micrel,fiber-mode" or "ti,fiber-mode".
> > > 
> > > The port description lives in its own file, as it is intended in the
> > > future to allow describing the ports for phy-less devices.
> > > 
> > > Reviewed-by: Andrew Lunn <andrew@...n.ch>
> > > Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>
> > > Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
> > > Tested-by: Christophe Leroy <christophe.leroy@...roup.eu>
> > > Signed-off-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
> > > ---
> > >   .../bindings/net/ethernet-connector.yaml      | 57 +++++++++++++++++++
> > >   .../devicetree/bindings/net/ethernet-phy.yaml | 18 ++++++
> > >   MAINTAINERS                                   |  1 +
> > >   3 files changed, 76 insertions(+)
> > >   create mode 100644 Documentation/devicetree/bindings/net/ethernet-connector.yaml
> > > 
> > 
> > My bot found errors running 'make dt_binding_check' on your patch:
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@...3000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> > Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@...3000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> > Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@...5000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> > Documentation/devicetree/bindings/thermal/thermal-sensor.example.dtb: /example-0/soc/thermal-sensor@...5000: failed to match any schema with compatible: ['qcom,sdm845-tsens', 'qcom,tsens-v2']
> 
> Those errors are unrelated to the blamed patch, the patch is about Ethernet
> the error is about thermal-sensors.

There was an assumption that the base (generally linux-next if not 
defined) works. That unfortunately was not the case when a patch applied 
introduced a tab char presumably as part of conflict resolution. So now 
almost every patch fails. Applying the months old patch was timed 
perfectly with my disappearing for US holidays as well as the merge 
window because as an added bonus it went into Linus' tree too. Anyways, 
Linus' tree and today's next are fixed now. The automated testing now 
aborts if the base has issues, so this shouldn't happen again (it will 
be for other reasons). So most of the patches aren't getting tested now 
until folks move of the broken linux-next versions.  

And thanks to all this, now Linus wants to change all kernel YAML files 
over to tabs instead. That's been my week...

Rob