linux-kernel - Re: [PATCH 3/3] mshv: Add debugfs to view hypervisor statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6704d1d1-9968-451a-8771-f4754b9a2126@linux.microsoft.com>
Date: Thu, 4 Dec 2025 10:57:31 -0800
From: Nuno Das Neves <nunodasneves@...ux.microsoft.com>
To: Stanislav Kinsburskii <skinsburskii@...ux.microsoft.com>
Cc: linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
 kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
 decui@...rosoft.com, longli@...rosoft.com, mhklinux@...look.com,
 prapal@...ux.microsoft.com, mrathor@...ux.microsoft.com,
 paekkaladevi@...ux.microsoft.com, Jinank Jain <jinankjain@...rosoft.com>
Subject: Re: [PATCH 3/3] mshv: Add debugfs to view hypervisor statistics

On 12/3/2025 11:21 AM, Stanislav Kinsburskii wrote:
> On Wed, Dec 03, 2025 at 09:53:25AM -0800, Nuno Das Neves wrote:
>> Introduce a debugfs interface to expose root and child partition stats
>> when running with mshv_root.
>>
> 
> <snip>
>> +static void mshv_debugfs_parent_partition_remove(void)
> 
> nit: it makes sense to add __exit to this method.
> 
> <snip>
> 
>> +
>> +void mshv_debugfs_exit(void)
> 
> Ditto.

It looks like __exit is purposely omitted here, because
mshv_debugfs_exit() is called in the error cleanup path of
mshv_parent_partition_init().

Thanks
Nuno

> 
> Reviewed-by: Stanislav Kinsburskii <skinsburskii@...ux.microsoft.com>
> 
> Thanks,
> Stanislav