linux-kernel - Re: [PATCH 1/3] PM: runtime: Stop checking pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iyR5x-FDoyoTp3ip7g7tdB_Qmii5Uy+EtCOpLyy2XBJg@mail.gmail.com>
Date: Thu, 4 Dec 2025 20:41:34 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Guenter Roeck <linux@...ck-us.net>, Brian Norris <briannorris@...omium.org>
Cc: Len Brown <lenb@...nel.org>, Pavel Machek <pavel@...nel.org>, 
	Nicolas Palix <nicolas.palix@...g.fr>, linux-pm@...r.kernel.org, 
	Julia Lawall <Julia.Lawall@...ia.fr>, linux-kernel@...r.kernel.org, cocci@...ia.fr
Subject: Re: [PATCH 1/3] PM: runtime: Stop checking pm_runtime_barrier()
 return code

On Wed, Dec 3, 2025 at 4:34 AM Guenter Roeck <linux@...ck-us.net> wrote:
>
> On Tue, Dec 02, 2025 at 11:30:24AM -0800, Brian Norris wrote:
> > Apparently this test is the only code that checks the return code from
> > pm_runtime_barrier(), and it turns out that's for good reason -- it's
> > inherently racy, and a bad idea. We're going to make
> > pm_runtime_barrier() return void, so prepare for that by dropping any
> > return code checks.
> >
> > This resolves some test failures seen like the following:
> >
> > [   34.559694]     # pm_runtime_error_test: EXPECTATION FAILED at drivers/base/power/runtime-test.c:177
> > [   34.559694]     Expected 1 == pm_runtime_barrier(dev), but
> > [   34.559694]         pm_runtime_barrier(dev) == 0 (0x0)
> > [   34.563604]     # pm_runtime_error_test: pass:0 fail:1 skip:0 total:1
> >
> > Reported-by: Guenter Roeck <linux@...ck-us.net>
> > Closes: https://lore.kernel.org/lkml/93259f2b-7017-4096-a31b-cabbf6152e9b@roeck-us.net/
> > Signed-off-by: Brian Norris <briannorris@...omium.org>
>
> With this series on top of v6.18:
>
> Qemu test results:
>         total: 610 pass: 610 fail: 0
> Unit test results:
>         pass: 666898 fail: 0
>
> Tested-by: Guenter Roeck <linux@...ck-us.net>

Applied along with the [2-3/3] as 6.19-rc material, thanks!