linux-kernel - Re: [PATCH v5 2/3] block: prohibit calls to bio_chain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTFW_gdWmXmCP5fd@infradead.org>
Date: Thu, 4 Dec 2025 01:40:14 -0800
From: Christoph Hellwig <hch@...radead.org>
To: zhangshida <starzhangzsd@...il.com>
Cc: Johannes.Thumshirn@....com, hch@...radead.org, agruenba@...hat.com,
	ming.lei@...hat.com, hsiangkao@...ux.alibaba.com,
	csander@...estorage.com, colyli@...as.com,
	linux-block@...r.kernel.org, linux-bcache@...r.kernel.org,
	linux-kernel@...r.kernel.org, zhangshida@...inos.cn
Subject: Re: [PATCH v5 2/3] block: prohibit calls to bio_chain_endio

On Thu, Dec 04, 2025 at 10:47:47AM +0800, zhangshida wrote:
> From: Shida Zhang <zhangshida@...inos.cn>
> 
> Now that all potential callers of bio_chain_endio have been
> eliminated, completely prohibit any future calls to this function.
> 
> Suggested-by: Ming Lei <ming.lei@...hat.com>
> Suggested-by: Andreas Gruenbacher <agruenba@...hat.com>
> Suggested-by: Christoph Hellwig <hch@...radead.org>
> Signed-off-by: Shida Zhang <zhangshida@...inos.cn>
> ---
>  block/bio.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/block/bio.c b/block/bio.c
> index b3a79285c27..cfb751dfcf5 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -320,9 +320,13 @@ static struct bio *__bio_chain_endio(struct bio *bio)
>  	return parent;
>  }
>  
> +/**
> + * This function should only be used as a flag and must never be called.
> + * If execution reaches here, it indicates a serious programming error.
> + */

This is not a kerneldoc comment and thus should not use /** to start
the comment, otherwise the kerneldoc script will complain about
missing kernel doc elelemts.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>