linux-kernel - Re: [PATCH 2/2] PCI: Fix the PCIe bridge decreasing to Gen 1 during hotplug testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251204014020.1426-1-mattc@purestorage.com>
Date: Wed,  3 Dec 2025 18:40:20 -0700
From: Matthew W Carlis <mattc@...estorage.com>
To: macro@...am.me.uk
Cc: ahuang12@...ovo.com,
	alok.a.tiwari@...cle.com,
	ashishk@...estorage.com,
	bamstadt@...estorage.com,
	bhelgaas@...gle.com,
	guojinhui.liam@...edance.com,
	ilpo.jarvinen@...ux.intel.com,
	jiwei.sun.bj@...com,
	linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org,
	lukas@...ner.de,
	mattc@...estorage.com,
	msaggi@...estorage.com,
	sconnor@...estorage.com,
	sunjw10@...ovo.com
Subject: Re: [PATCH 2/2] PCI: Fix the PCIe bridge decreasing to Gen 1 during hotplug testing

On  Mon, 1 Dec 2025, Maciej W. Rozycki wrote:

> Discard Vendor:Device ID matching in the PCIe failed link retraining 
> quirk and ignore the link status for the removal of the 2.5GT/s speed 
> clamp, whether applied by the quirk itself or the firmware earlier on.  
> Revert to the original target link speed if this final link retraining 
> has failed.

I think we should either remove the quirk or only execute the quirk when the
downstream port is the specific ASMedia 0x2824. Hardware companies that
develop PCIe devices rely on the linux kernel for a significant amount of
their testing & the action taken by this quirk is going to introduce
noise into those tests by initiating unexpected speed changes etc.

As long as we have this quirk messing with link speeds we'll just
continue to see issue reports over time in my opinion.