linux-kernel - Re: [PATCH v2 1/1] scsi: core: Fix error handler encryption support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTFe48CQcpCt6bm8@infradead.org>
Date: Thu, 4 Dec 2025 02:13:55 -0800
From: Christoph Hellwig <hch@...radead.org>
To: Bart Van Assche <bvanassche@....org>
Cc: Christoph Hellwig <hch@...radead.org>, Po-Wen Kao <powenkao@...gle.com>,
	Hannes Reinecke <hare@...e.com>,
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	"open list:SCSI SUBSYSTEM" <linux-scsi@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] scsi: core: Fix error handler encryption support

On Wed, Dec 03, 2025 at 05:57:49AM -1000, Bart Van Assche wrote:
> That would make it impossible to submit SCSI commands from the SCSI
> error handler that read data, e.g. to check that the medium is still
> readable.

That's already impossible right now, because data mapping isn't handled
for EH commands.

> I think that the approach of this patch is better than
> requiring that every SCSI LLD driver that supports inline encryption
> only sets up inline encryption for commands that have a non-zero
> payload size.

There is exactly one such driver (ufshcd) and the error handler needs
to clean up how it sends commands anyway.