linux-kernel - Re: [PATCH] drm/panel: visionox-rm69299: add backlight dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aTFhBtzzKbN3mjqw@quark2.heme.sigxcpu.org>
Date: Thu, 4 Dec 2025 11:23:02 +0100
From: Guido Günther <agx@...xcpu.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Neil Armstrong <neil.armstrong@...aro.org>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
	Arnd Bergmann <arnd@...db.de>,
	Jessica Zhang <jesszhan0024@...il.com>,
	Svyatoslav Ryhel <clamor95@...il.com>,
	David Heidelberg <david@...t.cz>,
	Linus Walleij <linus.walleij@...aro.org>,
	Kaustabh Chakraborty <kauschluss@...root.org>,
	Maxim Schwalm <maxim.schwalm@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Colin Ian King <colin.i.king@...il.com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel: visionox-rm69299: add backlight dependency

Hi,
On Thu, Dec 04, 2025 at 10:47:26AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The recently added backlight support breaks when CONFIG_BACKLIGHT_CLASS_DEVICE
> is turned off:
> 
> arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-visionox-rm69299.o: in function `visionox_rm69299_probe':
> panel-visionox-rm69299.c:(.text.visionox_rm69299_probe+0x92): undefined reference to `devm_backlight_device_register'
> arm-linux-gnueabi-ld: (devm_backlight_device_register): Unknown destination type (ARM/Thumb) in drivers/gpu/drm/panel/panel-visionox-rm69299.o
> 
> Add the appropriate Kconfig dependency.
> 
> Fixes: 7911d8cab554 ("drm/panel: visionox-rm69299: Add backlight support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks for looking at this. This is a duplicate of

  https://lore.kernel.org/phone-devel/20251017-visionox-rm69299-bl-v2-1-9dfa06606754@sigxcpu.org/

though, idk why it didn't get applied.

Cheers,
 -- Guido

> ---
>  drivers/gpu/drm/panel/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 76f6af819037..2923148dcf07 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -1163,6 +1163,7 @@ config DRM_PANEL_VISIONOX_R66451
>  
>  config DRM_PANEL_VISIONOX_RM69299
>  	tristate "Visionox RM69299"
> +	depends on BACKLIGHT_CLASS_DEVICE
>  	depends on OF
>  	depends on DRM_MIPI_DSI
>  	help
> -- 
> 2.39.5
>