linux-kernel - Re: [PATCH 4/6 v8] sched/fair: Add push task mechanism for fair

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251204104609.GH2528459@noisy.programming.kicks-ass.net>
Date: Thu, 4 Dec 2025 11:46:09 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Vincent Guittot <vincent.guittot@...aro.org>
Cc: mingo@...hat.com, juri.lelli@...hat.com, dietmar.eggemann@....com,
	rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
	vschneid@...hat.com, linux-kernel@...r.kernel.org,
	pierre.gondois@....com, kprateek.nayak@....com, qyousef@...alina.io,
	hongyan.xia2@....com, christian.loehle@....com,
	luis.machado@....com
Subject: Re: [PATCH 4/6 v8] sched/fair: Add push task mechanism for fair

On Tue, Dec 02, 2025 at 07:12:40PM +0100, Vincent Guittot wrote:


> +static void fair_add_pushable_task(struct rq *rq, struct task_struct *p)
> +{
> +	if (sched_push_task_enabled() && fair_push_task(rq, p)) {
> +		plist_del(&p->pushable_tasks, &rq->cfs.pushable_tasks);
> +		plist_node_init(&p->pushable_tasks, p->prio);
> +		plist_add(&p->pushable_tasks, &rq->cfs.pushable_tasks);
> +	}
> +}

I might have asked before, but if there was an answer, I have forgotten
:/

Why is this a prio-list? It seems to me that we don't particularly care
about keeping this push sorted by nice value, right?