linux-kernel - Re: [RFC v2 1/2] scsi: sd: fix write_same16 and write_same10 for sector size > PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79e77629-f243-4468-8571-58725af92d77@acm.org>
Date: Wed, 3 Dec 2025 15:59:44 -1000
From: Bart Van Assche <bvanassche@....org>
To: sw.prabhu6@...il.com, James.Bottomley@...senPartnership.com,
 martin.petersen@...cle.com, linux-scsi@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, mcgrof@...nel.org, kernel@...kajraghav.com,
 Swarna Prabhu <s.prabhu@...sung.com>, Pankaj Raghav <p.raghav@...sung.com>
Subject: Re: [RFC v2 1/2] scsi: sd: fix write_same16 and write_same10 for
 sector size > PAGE_SIZE

On 12/3/25 1:05 PM, sw.prabhu6@...il.com wrote:
>   static void *sd_set_special_bvec(struct request *rq, unsigned int data_len)
>   {
>   	struct page *page;
> +	struct scsi_device *sdp = scsi_disk(rq->q->disk)->device;

Instead of using this cumbersome approach to obtain the SCSI device
pointer, I recommend to change the 'struct request *rq' argument into
'struct scsi_cmnd *cmd' and to obtain the SCSI device pointer as
follows:

	struct scsi_device *sdp = cmd->device;

Otherwise this patch looks good to me.

Thanks,

Bart.