linux-kernel - Re: [PATCH] media: i2c: ov5647: use our own mutex for the ctrl lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <254356bd-0ea3-48a2-8a11-8f91cc8a099f@windriver.com>
Date: Thu, 4 Dec 2025 18:57:12 +0800
From: xiaolei wang <xiaolei.wang@...driver.com>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: dave.stevenson@...pberrypi.com, jacopo@...ndi.org, mchehab@...nel.org,
        prabhakar.mahadev-lad.rj@...renesas.com,
        laurent.pinchart@...asonboard.com, hverkuil+cisco@...nel.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: i2c: ov5647: use our own mutex for the ctrl lock


On 12/4/25 18:11, Sakari Ailus wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> Hi Xiaolei,
>
> On Mon, Dec 01, 2025 at 08:00:26AM +0800, Xiaolei Wang wrote:
>> __v4l2_ctrl_handler_setup() and __v4l2_ctrl_modify_range()
>> contains an assertion to verify that the v4l2_ctrl_handler::lock
>> is held, as it should only be called when the lock has already
>> been acquired. Therefore use our own mutex for the ctrl lock,
>> otherwise a warning will be  reported.
>>
>> Signed-off-by: Xiaolei Wang <xiaolei.wang@...driver.com>
>> ---
>>   drivers/media/i2c/ov5647.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c
>> index e193fef4fced..4e14eefba577 100644
>> --- a/drivers/media/i2c/ov5647.c
>> +++ b/drivers/media/i2c/ov5647.c
>> @@ -1288,9 +1288,12 @@ static int ov5647_init_controls(struct ov5647 *sensor)
>>   {
>>        struct i2c_client *client = v4l2_get_subdevdata(&sensor->sd);
>>        int hblank, exposure_max, exposure_def;
>> +     struct v4l2_ctrl_handler *hdl = &sensor->ctrls;
>>
>>        v4l2_ctrl_handler_init(&sensor->ctrls, 9);
>>
>> +     hdl->lock = &sensor->lock;
> You can use sensor->ctrls here; otherwise change the existing users first
> (but that should go to a separate patch anyway).

OK，I will send version 2.

thanks

xiaolei

>
>> +
>>        v4l2_ctrl_new_std(&sensor->ctrls, &ov5647_ctrl_ops,
>>                          V4L2_CID_AUTOGAIN, 0, 1, 1, 0);
>>
> --
> Kind regards,
>
> Sakari Ailus