linux-kernel - Re: [RFC v2 1/2] scsi: sd: fix write_same16 and write_same10 for sector size > PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <de6e39f9-476b-4867-ad55-1f3f3bfbe25d@acm.org>
Date: Wed, 3 Dec 2025 16:03:36 -1000
From: Bart Van Assche <bvanassche@....org>
To: sw.prabhu6@...il.com, James.Bottomley@...senPartnership.com,
 martin.petersen@...cle.com, linux-scsi@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, mcgrof@...nel.org, kernel@...kajraghav.com,
 Swarna Prabhu <s.prabhu@...sung.com>, Pankaj Raghav <p.raghav@...sung.com>
Subject: Re: [RFC v2 1/2] scsi: sd: fix write_same16 and write_same10 for
 sector size > PAGE_SIZE

On 12/3/25 1:05 PM, sw.prabhu6@...il.com wrote:
> -	if (sector_size != 512 &&
> -	    sector_size != 1024 &&
> -	    sector_size != 2048 &&
> -	    sector_size != 4096) {
> +	if (sector_size < 512 || sector_size > BLK_MAX_BLOCK_SIZE ||
> +	    !is_power_of_2(sector_size)) {
>   		sd_printk(KERN_NOTICE, sdkp, "Unsupported sector size %d.\n",
>   			  sector_size);
>   		/*

Please use blk_validate_block_size() instead of open-coding it.

Thanks,

Bart.