linux-kernel - Re: [PATCH v1 3/4] cpufreq: Centralize boost freq QoS requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5dded7af-51fc-4766-957b-1af044c52159@huawei.com>
Date: Thu, 4 Dec 2025 20:02:41 +0800
From: "zhenglifeng (A)" <zhenglifeng1@...wei.com>
To: Pierre Gondois <pierre.gondois@....com>
CC: <linux-kernel@...r.kernel.org>, Christian Loehle
	<christian.loehle@....com>, Ionela Voinescu <ionela.voinescu@....com>, Jie
 Zhan <zhanjie9@...ilicon.com>, Huang Rui <ray.huang@....com>, "Gautham R.
 Shenoy" <gautham.shenoy@....com>, Mario Limonciello
	<mario.limonciello@....com>, Perry Yuan <perry.yuan@....com>, "Rafael J.
 Wysocki" <rafael@...nel.org>, Viresh Kumar <viresh.kumar@...aro.org>,
	<linux-pm@...r.kernel.org>
Subject: Re: [PATCH v1 3/4] cpufreq: Centralize boost freq QoS requests

On 2025/12/4 18:13, Pierre Gondois wrote:
> policy_set_boost() calls the cpufreq set_boost callback.
> Update the newly added boost_freq_req request from there:
> - whenever boost is toggled
> - to cover all possible paths
> 
> Signed-off-by: Pierre Gondois <pierre.gondois@....com>
> ---
>  drivers/cpufreq/cpufreq.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 23f64346b80f8..9d98b98e7981c 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -603,10 +603,16 @@ static int policy_set_boost(struct cpufreq_policy *policy, bool enable)
>  	policy->boost_enabled = enable;
>  
>  	ret = cpufreq_driver->set_boost(policy, enable);
> -	if (ret)
> +	if (ret) {
>  		policy->boost_enabled = !policy->boost_enabled;
> +		return ret;
> +	}
>  
> -	return ret;
> +	ret = freq_qos_update_request(policy->boost_freq_req, policy->cpuinfo.max_freq);
> +	if (ret < 0)

I think policy->boost_enabled should be set to !policy->boost_enabled here,
too. It'll be confusing if users got an error but set the enabled flag
successfully.

> +		return ret;
> +
> +	return 0;
>  }
>  
>  static ssize_t store_local_boost(struct cpufreq_policy *policy,