linux-kernel - Re: [PATCH] drm/xe/pf: fix VFIO link error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64aa446c-eaea-40c6-982a-6308ab0b87dc@intel.com>
Date: Thu, 4 Dec 2025 13:10:58 +0100
From: Michal Wajdeczko <michal.wajdeczko@...el.com>
To: Arnd Bergmann <arnd@...nel.org>, Thomas Hellström
	<thomas.hellstrom@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Michał Winiarski <michal.winiarski@...el.com>
CC: Arnd Bergmann <arnd@...db.de>, Matthew Brost <matthew.brost@...el.com>,
	Lucas De Marchi <demarchi@...nel.org>, Jani Nikula <jani.nikula@...el.com>,
	Riana Tauro <riana.tauro@...el.com>, <intel-xe@...ts.freedesktop.org>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/xe/pf: fix VFIO link error



On 12/4/2025 10:41 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The Makefile logic for building xe_sriov_vfio.o was added incorrectly,
> as setting CONFIG_XE_VFIO_PCI=m means it doesn't get included into a
> built-in xe driver:
> 
> ERROR: modpost: "xe_sriov_vfio_stop_copy_enter" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_stop_copy_exit" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_suspend_device" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_wait_flr_done" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_error" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_resume_data_enter" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_resume_device" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_resume_data_exit" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_data_write" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_migration_supported" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> WARNING: modpost: suppressed 3 unresolved symbol warnings because there were too many)
> 
> Check for CONFIG_XE_VFIO_PCI being enabled in the Makefile to decide whether to
> include the the object instead.
> 
> Fixes: 17f22465c5a5 ("drm/xe/pf: Export helpers for VFIO")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@...el.com>

> ---
>  drivers/gpu/drm/xe/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
> index dfc2ded01455..e5f3c2ec9e9a 100644
> --- a/drivers/gpu/drm/xe/Makefile
> +++ b/drivers/gpu/drm/xe/Makefile
> @@ -185,8 +185,8 @@ xe-$(CONFIG_PCI_IOV) += \
>  	xe_sriov_pf_sysfs.o \
>  	xe_tile_sriov_pf_debugfs.o
>  
> -ifeq ($(CONFIG_PCI_IOV),y)
> -	xe-$(CONFIG_XE_VFIO_PCI) += xe_sriov_vfio.o
> +ifdef CONFIG_XE_VFIO_PCI
> +	xe-$(CONFIG_PCI_IOV) += xe_sriov_vfio.o
>  endif
>  
>  # include helpers for tests even when XE is built-in