linux-kernel - Re: [PATCH -next v2] mm: vmscan: correct nr_requested tracing in scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6320fb67-4ed7-43c4-a4b6-48ebed2b473f@linux.dev>
Date: Thu, 4 Dec 2025 21:35:53 +0800
From: Lance Yang <lance.yang@...ux.dev>
To: Chen Ridong <chenridong@...weicloud.com>
Cc: linux-mm@...ck.org, david@...nel.org, shakeel.butt@...ux.dev,
 zhengqi.arch@...edance.com, linux-kernel@...r.kernel.org,
 lujialin4@...wei.com, chenridong@...wei.com, hannes@...xchg.org,
 yuanchu@...gle.com, weixugc@...gle.com, axelrasmussen@...gle.com,
 akpm@...ux-foundation.org, lorenzo.stoakes@...cle.com, yuzhao@...gle.com,
 jaewon31.kim@...sung.com, mhocko@...nel.org, ioworker0@...il.com
Subject: Re: [PATCH -next v2] mm: vmscan: correct nr_requested tracing in
 scan_folios



On 2025/12/4 20:23, Chen Ridong wrote:
> From: Chen Ridong <chenridong@...wei.com>
> 
> When enabling vmscan tracing, it is observed that nr_requested is always
> 4096, which is confusing.
> 
>          mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ...
>          mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ...
>          mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ...
>          mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ...
>          mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ...
>          mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ...
>          mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ...
> 
> This is because it prints MAX_LRU_BATCH, which is meaningless as it's a
> constant. To fix this, modify it to print capped valued.
> 
> Fixes: 8c2214fc9a47 ("mm: multi-gen LRU: reuse some legacy trace events")
> Signed-off-by: Chen Ridong <chenridong@...wei.com>
> ---

LGTM, feel free to add:

Reviewed-by: Lance Yang <lance.yang@...ux.dev>