[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9794dcce-0c1d-4c30-8d07-47c50548b4c1@ixit.cz>
Date: Thu, 4 Dec 2025 14:43:33 +0100
From: David Heidelberg <david@...t.cz>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
Griffin Kroah-Hartman <griffin.kroah@...rphone.com>,
Dmitry Torokhov <dmitry.torokhov@...il.com>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Luca Weiss <luca.weiss@...rphone.com>
Cc: linux-input@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: milos-fairphone-fp6: Add vibrator
support
On 04/12/2025 14:34, Konrad Dybcio wrote:
> On 12/4/25 1:29 PM, Griffin Kroah-Hartman wrote:
>> Add the required node for haptic playback (Awinic AW86938)
>>
>> Signed-off-by: Griffin Kroah-Hartman <griffin.kroah@...rphone.com>
>> ---
>> arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 17 +++++++++++++++++
>
> The DTS is unfortunately still not merged :/
>
> Please arrange with Luca and either squash this into the resubmission
> (depending on how the driver changes go for the vibrator) or resend it
> afterwards
would be enough to provide dependency on the Luca patchset trough the
amazing
b4 prep --edit-deps
here?
David
>
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> index 0a758fb7f4d413a84cdae695c38616fc6075db67..8c43bc9c1d8312f22ad0aeed84b23d52910e0ca6 100644
>> --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> @@ -717,6 +717,16 @@ vreg_l7p: ldo7 {
>>
>> /* VL53L3 ToF @ 0x29 */
>> /* AW86938FCR vibrator @ 0x5a */
>
> You can remove this comment now
>
> The remainder of the patch lgtm
>
> Konrad
>
--
David Heidelberg
Powered by blists - more mailing lists