linux-kernel - Re: [PATCH net] broadcom: b44: prevent uninitialized value usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ea0d95d-1608-4937-a6a1-9babf6fb6770@lunn.ch>
Date: Thu, 4 Dec 2025 14:34:56 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Alexey Simakov <bigalex934@...il.com>
Cc: Michael Chan <michael.chan@...adcom.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Michael Buesch <mb@...sch.de>,
	"John W. Linville" <linville@...driver.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH net] broadcom: b44: prevent uninitialized value usage

On Thu, Dec 04, 2025 at 08:22:43AM +0300, Alexey Simakov wrote:
> On execution path with raised B44_FLAG_EXTERNAL_PHY, b44_readphy()
> leaves bmcr value uninitialized and it is used later in the code.
> 
> Add check of this flag at the beginning of the b44_nway_reset() and
> exit early of the function if an external PHY is used, that would
> also correspond to other b44_readphy() call sites.
> 
> Found by Linux Verification Center (linuxtesting.org) with Svace.
> 
> Fixes: 753f492093da ("[B44]: port to native ssb support")
> Signed-off-by: Alexey Simakov <bigalex934@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew