linux-kernel - Re: [PATCH net] broadcom: b44: prevent uninitialized value usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fddbad2c-8274-43c7-9b9f-e4b304a1b77b@lunn.ch>
Date: Thu, 4 Dec 2025 14:42:15 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Jonas Gorski <jonas.gorski@...il.com>
Cc: Alexey Simakov <bigalex934@...il.com>,
	Michael Chan <michael.chan@...adcom.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Michael Buesch <mb@...sch.de>,
	"John W. Linville" <linville@...driver.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH net] broadcom: b44: prevent uninitialized value usage

> > +++ b/drivers/net/ethernet/broadcom/b44.c
> > @@ -1789,6 +1789,9 @@ static int b44_nway_reset(struct net_device *dev)
> >  	u32 bmcr;
> >  	int r;
> >  
> > +	if (bp->flags & B44_FLAG_EXTERNAL_PHY)
> > +		return 0;
> 
> Wouldn't the right fix here to call phy_ethtool_nway_reset(dev->phydev); instead
> of just returning 0? That way it properly restarts auto-negotiation even in this
> case.

Actually, yes. ksettings_set() etc do exactly that. Let me change my
Reviewed by into a Change Request.

Thanks
    Andrew

---
pw-bot: cr