linux-kernel - Re: [PATCH] mm/damon/tests/core-kunit: avoid damos_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251204150151.83380-1-sj@kernel.org>
Date: Thu,  4 Dec 2025 07:01:50 -0800
From: SeongJae Park <sj@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: SeongJae Park <sj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Arnd Bergmann <arnd@...db.de>,
	Quanmin Yan <yanquanmin1@...wei.com>,
	damon@...ts.linux.dev,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/damon/tests/core-kunit: avoid damos_test_commit stack warning

On Thu,  4 Dec 2025 11:03:54 +0100 Arnd Bergmann <arnd@...nel.org> wrote:

> From: Arnd Bergmann <arnd@...db.de>
> 
> The newly added damos_test_commit() constructs multiple large structures
> on the stack, which exceeds the warning limit in some cases:
> 
> In file included from mm/damon/core.c:2941:
> mm/damon/tests/core-kunit.h: In function 'damos_test_commit':
> mm/damon/tests/core-kunit.h:965:1: error: the frame size of 1520 bytes is larger than 1280 bytes [-Werror=frame-larger-than=]
> 
> Split this function up into two separate ones that are called sequentially,
> so they can occupy the same stack slots.

Thank you for catching and fixing this, Arnd!

> 
> Fixes: 299a88f6ec13 ("mm/damon/tests/core-kunit: add damos_commit() test")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: SeongJae Park <sj@...nel.org>


Thanks,
SJ

[...]