[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <zi2btrqshzjwrmpu6uppaqvwn6tqbcnijizjoccqkoegce2sel@aa4hsy6yhabh>
Date: Thu, 4 Dec 2025 04:48:10 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Viken Dadhaniya <viken.dadhaniya@....qualcomm.com>
Cc: linux-kernel@...r.kernel.org, krzk@...nel.org, geert+renesas@...der.be,
bjorn.andersson@....qualcomm.com, arnd@...db.de, heiko@...ech.de,
ebiggers@...nel.org, michal.simek@....com, luca.weiss@...rphone.com,
nfraprado@...labora.com, prabhakar.mahadev-lad.rj@...renesas.com,
kuninori.morimoto.gx@...esas.com, mukesh.savaliya@....qualcomm.com,
linux-arm-msm@...r.kernel.org, trilok.soni@....qualcomm.com
Subject: Re: [PATCH 1/1] arm64: defconfig: Make I2C_QCOM_GENI built-in
On Thu, Dec 04, 2025 at 07:51:32AM +0530, Viken Dadhaniya wrote:
> Require I2C over GENI during early boot on some Qualcomm platforms to
Which "some Qualcomm platforms" are we talking about? You got that
feedback during internal review and... sadly you didn't improve your
commit message.
> initialize GPIO expanders that control SD card detection. Without this
> driver built-in, the kernel cannot detect the root filesystem device
> when modules are unavailable.
Please use initramfs to provide additional modules. Other boot-essential
drivers are also enabled as modules (CONFIG_BLK_DEV_NVME=m,
CONFIG_SCSI_UFS_QCOM=m).
>
> Make I2C_QCOM_GENI built-in to ensure these systems can boot without
> an initramfs.
>
> Signed-off-by: Viken Dadhaniya <viken.dadhaniya@....qualcomm.com>
> ---
> arch/arm64/configs/defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index cdb7d69e3b24..8d85a2255b07 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -562,7 +562,7 @@ CONFIG_I2C_OMAP=y
> CONFIG_I2C_OWL=y
> CONFIG_I2C_PXA=y
> CONFIG_I2C_QCOM_CCI=m
> -CONFIG_I2C_QCOM_GENI=m
> +CONFIG_I2C_QCOM_GENI=y
> CONFIG_I2C_QUP=y
> CONFIG_I2C_RIIC=y
> CONFIG_I2C_RK3X=y
> --
> 2.34.1
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists