linux-kernel - Re: [PATCH v2 2/3] of: factor arguments passed to of_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <75d44bf2-c518-444d-9b15-fca067e25877@oss.qualcomm.com>
Date: Fri, 5 Dec 2025 18:47:34 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Vijayanand Jitta <vijayanand.jitta@....qualcomm.com>, robin.murphy@....com,
        will@...nel.org, joro@...tes.org, robh@...nel.org,
        konrad.dybcio@....qualcomm.com, bjorn.andersson@....qualcomm.com,
        bod@...nel.org, conor+dt@...nel.org, krzk+dt@...nel.org,
        charan.kalla@....qualcomm.com, prakash.gupta@....qualcomm.com,
        vikash.garodia@....qualcomm.com
Cc: iommu@...ts.linux.dev, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/3] of: factor arguments passed to of_map_id() into a
 struct

On 04/12/2025 11:55, Vijayanand Jitta wrote:
> From: Charan Teja Kalla <charan.kalla@....qualcomm.com>
> 
> Introduce a new struct type where the optional arguments passed to
> of_map_id() are in struct. Subsequent patches add additional arguments
> to the struct that the caller expects to be filled of_map_id().

Why do we need a separate struct? Can't we use of_phandle_args instead?

> 
> Signed-off-by: Charan Teja Kalla <charan.kalla@....qualcomm.com>
> Signed-off-by: Vijayanand Jitta <vijayanand.jitta@....qualcomm.com>
> ---
>   drivers/iommu/of_iommu.c              |  6 +++++-
>   drivers/of/base.c                     | 31 ++++++++++++++-------------
>   drivers/pci/controller/dwc/pci-imx6.c |  6 +++++-
>   drivers/pci/controller/pcie-apple.c   |  5 ++++-
>   drivers/xen/grant-dma-ops.c           |  5 ++++-
>   include/linux/of.h                    | 23 ++++++++++++++------
>   6 files changed, 50 insertions(+), 26 deletions(-)
> 
-- 
With best wishes
Dmitry