linux-kernel - Re: [PATCH 2/2] bus: fsl-mc: Convert to bus callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <l3rm6hpfco7oterr3xfmlvvjr35ypirt5mfecrk4fn4golpm5l@rorig6egruji>
Date: Fri, 5 Dec 2025 18:39:32 +0100
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Ioana Ciornei <ioana.ciornei@....com>
Cc: linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 2/2] bus: fsl-mc: Convert to bus callbacks

Hello,

On Tue, Dec 02, 2025 at 03:09:20PM +0100, Uwe Kleine-König wrote:
> diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c
> index 0f0a5067f109..6bc163d2ca49 100644
> --- a/drivers/bus/fsl-mc/fsl-mc-bus.c
> +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
> [...]
> +static void fsl_mc_shutdown(struct device *dev)
> +{
> +	struct fsl_mc_driver *mc_drv = to_fsl_mc_driver(dev->driver);
> +	struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev);
> +
> +	if (mc_drv->shutdown)
> +		mc_drv->shutdown(mc_dev);
> +}

As the bus callback for shutdown is also called for unbound devices, the
condition has to be

	if (dev->driver && mc_drv->shutdown)
 		
Can you please squash this in, or should I resend?

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)