linux-kernel - Re: [PATCH v2 12/13] selftests/fs/mount-notify-ns: Fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45c3161a-0c57-40b0-9561-6e9d71f00049@roeck-us.net>
Date: Fri, 5 Dec 2025 10:26:18 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Amir Goldstein <amir73il@...il.com>
Cc: Shuah Khan <shuah@...nel.org>, Jakub Kicinski <kuba@...nel.org>,
 Christian Brauner <brauner@...nel.org>, Thomas Gleixner
 <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>, Kees Cook <kees@...nel.org>,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 wine-devel@...ehq.org, netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH v2 12/13] selftests/fs/mount-notify-ns: Fix build warning

On 12/5/25 09:31, Amir Goldstein wrote:
> On Fri, Dec 5, 2025 at 6:12 PM Guenter Roeck <linux@...ck-us.net> wrote:
>>
>> Fix
>>
>> mount-notify_test_ns.c: In function ‘fanotify_rmdir’:
>> mount-notify_test_ns.c:494:17: warning:
>>          ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’
>>
>> by checking the return value of chdir() and displaying an error message
>> if it returns an error.
>>
>> Fixes: 781091f3f5945 ("selftests/fs/mount-notify: add a test variant running inside userns")
>> Cc: Amir Goldstein <amir73il@...il.com>
>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>> ---
>> v2: Update subject and description to reflect that the patch fixes a build
>>      warning.
>>      Use perror() to display an error message if chdir() returns an error.
>>
>>   .../selftests/filesystems/mount-notify/mount-notify_test_ns.c  | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/filesystems/mount-notify/mount-notify_test_ns.c b/tools/testing/selftests/filesystems/mount-notify/mount-notify_test_ns.c
>> index 9f57ca46e3af..90bec6faf64e 100644
>> --- a/tools/testing/selftests/filesystems/mount-notify/mount-notify_test_ns.c
>> +++ b/tools/testing/selftests/filesystems/mount-notify/mount-notify_test_ns.c
>> @@ -491,7 +491,8 @@ TEST_F(fanotify, rmdir)
>>          ASSERT_GE(ret, 0);
>>
>>          if (ret == 0) {
>> -               chdir("/");
>> +               if (chdir("/"))
>> +                       perror("chdir()");
> 
> ASSERT_EQ(0, chdir("/"));
> 
> and there is another one like this in mount-notify_test.c
> 

Done.

Thanks,
Guenter