linux-kernel - Re: [PATCH v7 1/4] fixup! Drivers: hv: Introduce mshv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251205230806.GB1942423@liuwe-devbox-debian-v2.local>
Date: Fri, 5 Dec 2025 23:08:06 +0000
From: Wei Liu <wei.liu@...nel.org>
To: Praveen K Paladugu <prapal@...ux.microsoft.com>
Cc: kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
	decui@...rosoft.com, tglx@...utronix.de, mingo@...hat.com,
	linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
	bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org,
	hpa@...or.com, arnd@...db.de, anbelski@...ux.microsoft.com,
	easwar.hariharan@...ux.microsoft.com,
	nunodasneves@...ux.microsoft.com, skinsburskii@...ux.microsoft.com
Subject: Re: [PATCH v7 1/4] fixup! Drivers: hv: Introduce mshv_vtl driver

On Fri, Dec 05, 2025 at 11:06:24PM +0000, Wei Liu wrote:
> Please provide a proper commit subject.
> 
> On Fri, Dec 05, 2025 at 02:17:05PM -0600, Praveen K Paladugu wrote:
> > Drop the spurios "space" character in Makefile condition check
> > that causes mshv_common.o to be built regardless of the CONFIG settings.
> > 
> > Signed-off-by: Praveen K Paladugu <prapal@...ux.microsoft.com>
> > Suggested-by: Michael Kelley <mhklinux@...look.com>
> 
> This should come with a Fixes: tag.

Since the bug is not in any released kernel, so it is not needed.

I don't want to squash this though. So the request to have a proper
subject line still stands.

Wei

> 
> > ---
> >  drivers/hv/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/hv/Makefile b/drivers/hv/Makefile
> > index 58b8d07639f3..6d929fb0e13d 100644
> > --- a/drivers/hv/Makefile
> > +++ b/drivers/hv/Makefile
> > @@ -20,6 +20,6 @@ mshv_vtl-y := mshv_vtl_main.o
> >  # Code that must be built-in
> >  obj-$(CONFIG_HYPERV) += hv_common.o
> >  obj-$(subst m,y,$(CONFIG_MSHV_ROOT)) += hv_proc.o
> > -ifneq ($(CONFIG_MSHV_ROOT) $(CONFIG_MSHV_VTL),)
> > +ifneq ($(CONFIG_MSHV_ROOT)$(CONFIG_MSHV_VTL),)
> >  	obj-y += mshv_common.o
> >  endif
> > -- 
> > 2.51.0
> >