Message-ID: <aa75c5a4-27cf-4cc2-9851-07713999f469@hetzner.com>
Date: Thu, 4 Dec 2025 23:29:16 +0100
From: Tan Siewert <tan.siewert@...zner.com>
To: Rebecca Cran <rebecca@...io.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>,
 Andrew Jeffery <andrew@...econstruct.com.au>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org
Cc: Billy Tsai <billy_tsai@...eedtech.com>
Subject: Re: [PATCH v3 2/3] ARM: dts: aspeed: add device tree for ASRock Rack
 ALTRAD8 BMC

Hiya,

Please see the comments below.

-- Tan

On 04.12.25 22:02, Rebecca Cran wrote:
> The ALTRAD8 BMC is an Aspeed AST2500-based BMC for the ASRock Rack
> ALTRAD8UD-1L2T and ALTRAD8UD2-1L2Q boards.
> 
> Signed-off-by: Rebecca Cran <rebecca@...io.com>
> ---
>   arch/arm/boot/dts/aspeed/Makefile                      |   1 +
>   arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts | 612 ++++++++++++++++++++
>   2 files changed, 613 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile
> index 0f0b5b707654..9fd42a30c56d 100644
> --- a/arch/arm/boot/dts/aspeed/Makefile
> +++ b/arch/arm/boot/dts/aspeed/Makefile
> @@ -9,6 +9,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>   	aspeed-bmc-ampere-mtjefferson.dtb \
>   	aspeed-bmc-ampere-mtmitchell.dtb \
>   	aspeed-bmc-arm-stardragon4800-rep2.dtb \
> +	aspeed-bmc-asrock-altrad8.dtb \
>   	aspeed-bmc-asrock-e3c246d4i.dtb \
>   	aspeed-bmc-asrock-e3c256d4i.dtb \
>   	aspeed-bmc-asrock-romed8hm3.dtb \
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts
> new file mode 100644
> index 000000000000..2696a8692607
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts
> @@ -0,0 +1,612 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/dts-v1/;
> +
> +#include "aspeed-g5.dtsi"
> +#include <dt-bindings/gpio/aspeed-gpio.h>
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/i2c/i2c.h>
> +
> +/ {
> +	model = "ASRock ALTRAD8 BMC";
> +	compatible = "asrock,altrad8-bmc", "aspeed,ast2500";
> +
> +	aliases {
> +		serial4 = &uart5;
> +		i2c50 = &nvme1;
> +		i2c51 = &pcie4;
> +		i2c52 = &pcie5;
> +		i2c53 = &pcie6;
> +		i2c54 = &pcie7;
> +		i2c55 = &nvme3;
> +		i2c56 = &nvme2;
> +		i2c57 = &nvme0;
> +		i2c58 = &nvme4;
> +		i2c59 = &nvme5;
> +		i2c60 = &nvme6;
> +		i2c61 = &nvme7;
> +		i2c62 = &nvme8;
> +		i2c63 = &nvme9;
> +		i2c64 = &nvme10;
> +		i2c65 = &nvme11;
> +	};
> +
> +	chosen {
> +		stdout-path = "uart5:115200n8";
> +	};
> +
> +	iio-hwmon {
> +		compatible = "iio-hwmon";
> +		io-channels =	<&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>,
> +				<&adc 4> ,<&adc 5>, <&adc 6>, <&adc 7>,
> +				<&adc 8>, <&adc 9>, <&adc 10>, <&adc 11>,
> +				<&adc 12>, <&adc 13>, <&adc 14>, <&adc 15>;
> +	};
> +
> +	leds {
> +		compatible = "gpio-leds";
> +

What is the reason for the removal of the `system-fault` led?

> +		led-heartbeat {
> +			gpios = <&gpio ASPEED_GPIO(G,0) GPIO_ACTIVE_LOW>;
> +			label = "platform:green:heartbeat";
> +			color = <LED_COLOR_ID_GREEN>;
> +			function = LED_FUNCTION_INDICATOR;

Maybe add `linux,default-trigger = "timer";`?

> +		};
> +
> +		led-fan1-fault {
> +			retain-state-shutdown;
> +			default-state = "off";
> +			gpios = <&io_expander0 0 GPIO_ACTIVE_LOW>;
> +			label = "fan1:red:fault";
> +			color = <LED_COLOR_ID_RED>;
> +			function = LED_FUNCTION_FAULT;
> +		};
> +
> +		led-fan2-fault {
> +			retain-state-shutdown;
> +			default-state = "off";
> +			gpios = <&io_expander0 1 GPIO_ACTIVE_LOW>;
> +			label = "fan2:red:fault";
> +			color = <LED_COLOR_ID_RED>;
> +			function = LED_FUNCTION_FAULT;
> +		};
> +
> +		led-fan3-fault {
> +			retain-state-shutdown;
> +			default-state = "off";
> +			gpios = <&io_expander0 2 GPIO_ACTIVE_LOW>;
> +			label = "fan3:red:fault";
> +			color = <LED_COLOR_ID_RED>;
> +			function = LED_FUNCTION_FAULT;
> +		};
> +
> +		led-fan4-fault {
> +			retain-state-shutdown;
> +			default-state = "off";
> +			gpios = <&io_expander0 3 GPIO_ACTIVE_LOW>;
> +			label = "fan4:red:fault";
> +			color = <LED_COLOR_ID_RED>;
> +			function = LED_FUNCTION_FAULT;
> +		};
> +
> +		led-fan5-fault {
> +			retain-state-shutdown;
> +			default-state = "off";
> +			gpios = <&io_expander0 4 GPIO_ACTIVE_LOW>;
> +			label = "fan5:red:fault";
> +			color = <LED_COLOR_ID_RED>;
> +			function = LED_FUNCTION_FAULT;
> +		};
> +	};
> +
> +	memory@...00000 {
> +		reg = <0x80000000 0x20000000>;
> +	};
> +
> +	reserved-memory {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		gfx_memory: framebuffer {
> +			compatible = "shared-dma-pool";
> +			size = <0x01000000>;
> +			alignment = <0x01000000>;
> +			reusable;
> +		};
> +
> +		vga_memory: framebuffer@...00000 {
> +			no-map;
> +			reg = <0x9f000000 0x01000000>; /* 16M */
> +		};
> +
> +		video_engine_memory: jpegbuffer {
> +			compatible = "shared-dma-pool";
> +			size = <0x02000000>;	/* 32M */
> +			alignment = <0x01000000>;
> +			reusable;
> +		};
> +	};
> +};
> +
> +&adc {
> +	status = "okay";

I'm not sure if you have to explicitly set pinctrl-0 for ADC.

> +};
> +
> +&fmc {
> +	status = "okay";
> +
> +	flash@0 {
> +		label = "bmc";
> +		m25p,fast-read;
> +		spi-max-frequency = <50000000>;
> +		status = "okay";
> +#include "openbmc-flash-layout-64.dtsi"
> +	};
> +};
> +
> +&gfx {
> +	memory-region = <&gfx_memory>;
> +	status = "okay";
> +};
> +
> +&gpio {
> +	gpio-line-names =
> +	/*A0-A7*/	"","","","bmc-ready","","","","",
> +	/*B0-B7*/	"i2c-backup-sel","","","","","","","host0-shd-ack-n",
> +	/*C0-C7*/	"","","","","","","","",
> +	/*D0-D7*/	"power-button","power-out","button-reset",
> +			"host0-sysreset-n","","","power-chassis-good","",
> +	/*E0-E7*/	"","s0-vrd1-vddq0123-fault-n",
> +			"s0-vrd1-vddq4567-fault-n","s0-vrd0-vddc-fault-n",
> +			"s0-vrd3-p0v75-fault-n","","","",
> +	/*F0-F7*/	"","","ps-atx-on-n","","","","","",
> +	/*G0-G7*/	"led-identify","button-identify","","","uboot-ready",\

`button-identify` should be `button-identify-n` (active-low).

`led-system-fault-n` is GPIOG3.

`led-identify-n` _could_ be at GPIOQ6 (seems to be wired to the CPLD (?!)).

> +			"bmc-salt2-n","","",
> +	/*H0-H7*/	"ps-pwr-ok","uart1-mode1","uart2-mode1","uart3-mode1",
> +			"uart4-mode1","","led-bmc-heartbeat","",

GPIOH6 is `BMC_JTAG_SEL_S0`. The `led-bmc-hearbeat-n` should be GPIOG0.

> +	/*I0-I7*/	"","","","","","","","",
> +	/*J0-J7*/	"s0-hightemp-n","","","","","","","",
> +	/*K0-K7*/	"","","","","","","","",
> +	/*L0-L7*/	"","","","","","","","",
> +	/*M0-M7*/	"","","","","","s0-spi-auth-fail-n","","",
> +	/*N0-N7*/	"","","","","","","","",
> +	/*O0-O7*/	"","","","","","","","",
> +	/*P0-P7*/	"","","cpld-disable-bmc","","","","","",

`cpld-disable-bmc` should be `cpld-disable-bmc-n` and at GPIOM0 
(`CPLD_DISABLE_BMC_L` in schematic). GPIOP2 is a fan tacho.

> +	/*Q0-Q7*/	"","","ext-hightemp-n","","","","",

double assignment of `ext-hightemp-n`. Correct one is GPIOR2. Please 
remove it.

> +			"chassis-intrusion",

`chassis-intrusion-n` (active-low).

> +	/*R0-R7*/	"","","ext-hightemp-n","spi0-program-sel","",
> +			"hwm-bat-en","","",

`hwm-bat-en` could be prefixed with `output-`.

> +	/*S0-S7*/	"s0-vr-hot-n","","","bmc-sysreset-n","","","","",

GPIOS2 (`input-salt5-n`) _could_ be useful (comes from the X550 for WoL 
(`LAN_3V3STBY_ALRT_N` in schematic)).

> +	/*T0-T7*/	"","","","","","","","",
> +	/*U0-U7*/	"","","","","","","","",
> +	/*V0-V7*/	"","","","","","","","",
> +	/*W0-W7*/	"","","","","","","","",
> +	/*X0-X7*/	"","","","","","","","",
> +	/*Y0-Y7*/	"sio-s3","sio-s5","sio-pwr-req","sio-on-ctrl","","","","",
> +	/*Z0-Z7*/	"","sio-pwr-good","","s0-rtc-lock","","","","",

System has no Super-IO. Please remove the `sio-` assignments.

> +	/*AA0-AA7*/	"rtc-int","","","","","pmbus-sel-n","","",

`rtc-int` should be `s0-rtc-int-n`.

> +	/*AB0-AB7*/	"host0-reboot-ack-n","s0-sys-auth-failure-n",
> +			"","","","","","",
> +	/*AC0-AC7*/	"s0-fault-alert","host0-ready","s0-overtemp-n",
> +			"","bmc-ok","host0-special-boot","presence-cpu0",
> +			"host0-shd-req-n";
> +
> +	status = "okay";
> +};
> +
> +&i2c0 {
> +	status = "okay";
> +
> +	ipmb@10 {
> +		compatible = "ipmb-dev";
> +		reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> +		i2c-protocol;
> +	};
> +
> +};
> +
> +&i2c1 {
> +	status = "okay";
> +
> +	i2c-mux1@73 {
> +		compatible = "nxp,pca9548";
> +		reg = <0x73>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		i2c-mux-idle-disconnect;
> +
> +		nvme1: i2c@0 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0>;
> +		};
> +
> +		pcie4: i2c@1 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <1>;
> +		};
> +
> +		pcie5: i2c@2 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <2>;
> +		};
> +
> +		pcie6: i2c@3 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <3>;
> +		};
> +
> +		pcie7: i2c@4 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <4>;
> +		};
> +
> +		nvme3: i2c@5 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <5>;
> +		};
> +
> +		nvme2: i2c@6 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <6>;
> +		};
> +
> +		nvme0: i2c@7 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <7>;
> +		};
> +	};
> +
> +	i2c-mux2@75 {
> +		compatible = "nxp,pca9548";
> +		reg = <0x75>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		i2c-mux-idle-disconnect;
> +
> +		nvme4: i2c@0 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0>;
> +		};
> +
> +		nvme5: i2c@1 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <1>;
> +		};
> +
> +		nvme6: i2c@2 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <2>;
> +		};
> +
> +		nvme7: i2c@3 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <3>;
> +		};
> +
> +		nvme8: i2c@4 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <4>;
> +		};
> +
> +		nvme9: i2c@5 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <5>;
> +		};
> +
> +		nvme10: i2c@6 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <6>;
> +		};
> +
> +		nvme11: i2c@7 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <7>;
> +		};
> +	};
> +};
> +
> +&i2c2 {
> +	status = "okay";
> +
> +	smpro@4f {
> +		compatible = "ampere,smpro";
> +		reg = <0x4f>;
> +	};
> +};
> +
> +&i2c3 {
> +	status = "okay";
> +
> +	// PSU FRU
> +	eeprom@38 {
> +		compatible = "atmel,24c02";
> +		reg = <0x38>;
> +	};
> +};
> +
> +&i2c4 {
> +	status = "okay";
> +
> +	temperature-sensor@29 {
> +		compatible = "nuvoton,nct7802";
> +		reg = <0x29>;
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		channel@0 { /* LTD */
> +			reg = <0>;
> +			status = "okay";
> +		};
> +
> +		channel@1 { /* RTD1 */
> +			reg = <1>;
> +			sensor-type = "temperature";
> +			temperature-mode = "thermistor";
> +		};
> +
> +		channel@2 { /* RTD2 */
> +			reg = <2>;
> +			sensor-type = "temperature";
> +			temperature-mode = "thermal-diode";
> +		};
> +	};
> +
> +	temperature-sensor@4c {
> +		compatible = "nuvoton,w83773g";
> +		reg = <0x4c>;
> +	};
> +};
> +
> +&i2c5 {
> +	status = "okay";
> +};
> +
> +&i2c6 {
> +	status = "okay";
> +
> +	rtc@6f {
> +		compatible = "isil,isl1208";
> +		reg = <0x6f>;
> +	};
> +};
> +
> +&i2c7 {
> +	status = "okay";
> +
> +	// BMC FRU
> +	eeprom@57 {
> +		compatible = "atmel,24c128";
> +		reg = <0x57>;
> +
> +		nvmem-layout {
> +			compatible = "fixed-layout";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
> +			eth1_macaddress: macaddress@...0 {
> +				reg = <0x3f80 6>;
> +			};
> +
> +			eth0_macaddress: macaddress@...8 {
> +				reg = <0x3f88 6>;
> +			};

Please add a comment explaining that 0x3f88 as offset is indeed the MAC 
for eth0 / the RTL8211E interface and not a typo.

> +		};
> +	};
> +};
> +
> +&i2c8 {
> +	status = "okay";
> +
> +	io_expander0: gpio@1c {
> +		compatible = "nxp,pca9557";
> +		reg = <0x1c>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +	};
> +};
> +
> +&i2c9 {
> +	status = "okay";
> +};
> +
> +&i2c10 {
> +	status = "okay";
> +};
> +
> +&i2c11 {
> +	status = "okay";
> +};
> +
> +&i2c12 {

Please add a comment that this is the I2C Bus for accessing the SCP EEPROM.

> +	status = "okay";
> +};
> +
> +&i2c13 {
> +	status = "okay";
> +
> +	ssif-bmc@10 {
> +		compatible = "ssif-bmc";
> +		reg = <0x10>;
> +	};
> +};
> +
> +// Connected to host Intel X550 (ALTRAD8UD-1L2T) or
> +// Broadcom BCM57414 (ALTRAD8UD2-1L2Q) interface

mac0 is unconnected for the ALTRAD8UD-1L (not 1L2T).

> +&mac0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_rmii1_default>;
> +	clocks = <&syscon ASPEED_CLK_GATE_MAC1CLK>,
> +		 <&syscon ASPEED_CLK_MAC1RCLK>;
> +	clock-names = "MACCLK", "RCLK";
> +	use-ncsi;
> +	nvmem-cells = <&eth0_macaddress>;
> +	nvmem-cell-names = "mac-address";
> +
> +	status = "okay";
> +};
> +
> +// Connected to Realtek RTL8211E
> +&mac1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>;
> +
> +	nvmem-cells = <&eth1_macaddress>;
> +	nvmem-cell-names = "mac-address";
> +
> +	status = "okay";
> +};
> +
> +&pinctrl {
> +	aspeed,external-nodes = <&gfx &lhc>;
> +};
> +
> +&pwm_tacho {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_pwm0_default
> +			&pinctrl_pwm1_default
> +			&pinctrl_pwm2_default
> +			&pinctrl_pwm3_default
> +			&pinctrl_pwm4_default
> +			&pinctrl_pwm5_default
> +			&pinctrl_pwm6_default
> +			&pinctrl_pwm7_default>;
> +
> +	status = "okay";
> +
> +	fan@0 {
> +		reg = <0x00>;
> +		aspeed,fan-tach-ch = /bits/ 8 <0x00 0x08>;
> +	};
> +
> +	fan@1 {
> +		reg = <0x01>;
> +		aspeed,fan-tach-ch = /bits/ 8 <0x01 0x09>;
> +	};
> +
> +	fan@2 {
> +		reg = <0x02>;
> +		aspeed,fan-tach-ch = /bits/ 8 <0x02 0x0a>;
> +	};
> +
> +	fan@3 {
> +		reg = <0x03>;
> +		aspeed,fan-tach-ch = /bits/ 8 <0x03 0x0b>;
> +	};
> +
> +	fan@4 {
> +		reg = <0x04>;
> +		aspeed,fan-tach-ch = /bits/ 8 <0x04 0x0c>;
> +	};
> +
> +	fan@5 {
> +		reg = <0x05>;
> +		aspeed,fan-tach-ch = /bits/ 8 <0x05 0x0d>;
> +	};
> +
> +	fan@6 {
> +		reg = <0x06>;
> +		aspeed,fan-tach-ch = /bits/ 8 <0x06 0x0e>;
> +	};
> +
> +	fan@7 {
> +		reg = <0x07>;
> +		aspeed,fan-tach-ch = /bits/ 8 <0x07 0x0f>;
> +	};
> +};
> +
> +&spi1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_spi1_default>;
> +
> +	status = "okay";
> +
> +	// Host BIOS/UEFI EEPROM
> +	flash@0 {
> +		m25p,fast-read;
> +		label = "pnor";
> +		spi-max-frequency = <100000000>;
> +		status = "okay";
> +
> +		partitions {
> +			compatible = "fixed-partitions";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
> +			tfa@...000 {
> +				reg = <0x400000 0x200000>;
> +				label = "pnor-tfa";
> +			};
> +
> +			uefi@...000 {
> +				reg = <0x600000 0x1A00000>;
> +				label = "pnor-uefi";
> +			};
> +		};
> +	};
> +};
> +
> +&uart1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_txd1_default
> +			 &pinctrl_rxd1_default
> +			 &pinctrl_ncts1_default
> +			 &pinctrl_nrts1_default>;
> +
> +	status = "okay";
> +};
> +
> +&uart2 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_txd2_default
> +			&pinctrl_rxd2_default>;
> +
> +	status = "okay";
> +};
> +
> +&uart3 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_txd3_default
> +			&pinctrl_rxd3_default>;
> +
> +	status = "okay";
> +};
> +
> +&uart4 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_txd4_default
> +			&pinctrl_rxd4_default>;
> +
> +	status = "okay";
> +};
> +
> +// The BMC's uart
> +&uart5 {
> +	status = "okay";
> +};
> +
> +&vhub {
> +	status = "okay";
> +};
> +
> +&video {
> +	memory-region = <&video_engine_memory>;
> +
> +	status = "okay";
> +};


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (841 bytes)

Powered by blists - more mailing lists