linux-kernel - Re: [PATCH v4] staging: greybus: arche-apb-ctrl: switch to device_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aTKJSmE_FdT9AUpq@stanley.mountain>
Date: Fri, 5 Dec 2025 10:27:06 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Julioccps <julio191096@...il.com>
Cc: hvaibhav.linux@...il.com, johan@...nel.org, elder@...nel.org,
	gregkh@...uxfoundation.org, greybus-dev@...ts.linaro.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] staging: greybus: arche-apb-ctrl: switch to
 device_property_read_bool

On Thu, Dec 04, 2025 at 08:17:53PM -0300, Julioccps wrote:
> Switch from the deprecated of_property_read_bool() to the common
> device_property_read_bool() API. This makes the driver agnostic to
> the underlying firmware interface (DT or ACPI) and simplifies the
> logic.
> 
> Since the driver is no longer strictly dependent on Device Tree,
> include <linux/mod_devicetable.h> directly for the struct
> of_device_id definition, instead of relying on implicit inclusion
> via <linux/of_irq.h>, which has been removed as it is unused.
> 
> Also rename apb_ctrl_get_devtree_data() to apb_ctrl_get_fw_data()
> to better reflect the agnostic nature of the new implementation.
> 
> Signed-off-by: Julio Cesar Carvalho de Paula Souza <julio191096@...il.com>
> ---

Same comments as v3.

regards,
dan carpenter