linux-kernel - Re: [PATCH] gpio: tb10x: fix OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=Mf65TkjnWG6rEqx95za4miO_gU459B87-SOYiZZmu2PaA@mail.gmail.com>
Date: Fri, 5 Dec 2025 09:40:10 +0100
From: Bartosz Golaszewski <brgl@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Linus Walleij <linusw@...nel.org>, Arnd Bergmann <arnd@...db.de>, Peng Fan <peng.fan@....com>, 
	Lee Jones <lee@...nel.org>, Koichiro Den <koichiro.den@...onical.com>, 
	Christophe Leroy <chleroy@...nel.org>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: tb10x: fix OF_GPIO dependency

On Thu, Dec 4, 2025 at 10:50 AM Arnd Bergmann <arnd@...nel.org> wrote:
>
> From: Arnd Bergmann <arnd@...db.de>
>
> Selecting OF_GPIO is generally not allowed, it always gets enabled
> when both GPIOLIB and OF are turned on.
>
> The tb10x driver now warns about this after it was enabled for
> compile-testing:
>
> WARNING: unmet direct dependencies detected for OF_GPIO
>   Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
>   Selected by [y]:
>   - GPIO_TB10X [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (ARC_PLAT_TB10X || COMPILE_TEST [=y])
>
> Use the usual 'depends on' here.
>
> Fixes: 682fbb18e14c ("gpio: tb10x: allow building the module with COMPILE_TEST=y")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Hi Arnd!

Actually a better fix is to simply drop this select and not introduce
the depends on. This driver doesn't call any symbols from gpiolib-of.h
and even then - they provide stubs. This also limits the COMPILE_TEST
coverage to systems with OF_GPIO selected.

Same for the other patch you sent.

Bart