linux-kernel - Re: [PATCH v8 20/22] wifi: nxpwifi: add NXP vendor and IW61x device IDs to sdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98cc00f5-344e-4eaa-849f-091d1699dcbc@kernel.org>
Date: Fri, 5 Dec 2025 08:46:31 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jeff Chen <jeff.chen_1@....com>, linux-wireless@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, briannorris@...omium.org,
 johannes@...solutions.net, francesco@...cini.it, tsung-hsien.hsieh@....com,
 s.hauer@...gutronix.de
Subject: Re: [PATCH v8 20/22] wifi: nxpwifi: add NXP vendor and IW61x device
 IDs to sdio_ids.h

On 05/12/2025 07:55, Jeff Chen wrote:
> Register NXP's SDIO vendor ID (0x0471) and IW61x device ID (0x0205)
> in the global SDIO ID list. This allows the nxpwifi SDIO driver to
> match and bind to supported NXP Wi-Fi chips via the SDIO bus.

Only limited review because you did not care to even cc maintainers -
don't describe drivers. Describe hardware.

> 
> Signed-off-by: Jeff Chen <jeff.chen_1@....com>
> ---
>  .../bindings/net/wireless/nxp,iw61x.yaml      | 85 +++++++++++++++++++
>  include/linux/mmc/sdio_ids.h                  |  3 +
>  2 files changed, 88 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/wireless/nxp,iw61x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/nxp,iw61x.yaml b/Documentation/devicetree/bindings/net/wireless/nxp,iw61x.yaml
> new file mode 100644
> index 000000000000..358714796868
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/wireless/nxp,iw61x.yaml
> @@ -0,0 +1,85 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/wireless/nxp,iw61x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP IW61x SDIO devices
> +
> +maintainers:
> +  - Jeff Chen <jeff.chen_1@....com>
> +
> +description:
> +  This node provides properties for describing the NXP SDIO wireless device.

Describe hardware, not DT. We know how DT works.

Not reviewing the rest, NAK.

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.

Best regards,
Krzysztof