linux-kernel - Re: [PATCH v7 2/2] regulator: max77675: Add MAX77675 regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2559bbc4-290b-456b-80d1-1b188d98b046@kernel.org>
Date: Fri, 5 Dec 2025 08:52:39 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Joan-Na-adi <joan.na.devcode@...il.com>,
 Liam Girdwood <lgirdwood@...il.com>
Cc: Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, Joan Na <joan.na@...log.com>
Subject: Re: [PATCH v7 2/2] regulator: max77675: Add MAX77675 regulator driver

On 05/12/2025 05:56, Joan-Na-adi wrote:
> +
> +	if (int_glbl & MAX77675_INT_EN_R_BIT)
> +		dev_dbg(maxreg->dev, "nEN Rising Edge Interrupt occurred\n");
> +
> +	if (int_glbl & MAX77675_INT_EN_F_BIT)
> +		dev_dbg(maxreg->dev, "nEN Falling Edge Interrupt occurred\n");
> +
> +	return 0;
> +}
> +
> +static int max77675_regulator_probe(struct i2c_client *client)
> +{
> +	struct max77675_regulator *maxreg;
> +	struct regulator_config config = {};
> +	struct device_node *regulators_np __free(device_node) = NULL;

This is an undesired syntax explicitly documented as one to avoid. You
need here proper assignment, not NULL. Please don't use cleanup.h if you
do not intend to follow it because it does not make the code simpler.


Best regards,
Krzysztof