linux-kernel - Re: [PATCH v4 09/12] arm64: dts: qcom: sdm845-lg-common: Add camera flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8ab2b4ea-6148-41e7-b700-559d34817a44@oss.qualcomm.com>
Date: Fri, 5 Dec 2025 11:32:30 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Paul Sajna <sajattack@...tmarketos.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>, David Heidelberg <david@...t.cz>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, phone-devel@...r.kernel.org,
        Amir Dahan <system64fumo@...tonmail.com>,
        Christopher Brown <crispybrown@...il.com>
Subject: Re: [PATCH v4 09/12] arm64: dts: qcom: sdm845-lg-common: Add camera
 flash

On 12/4/25 7:37 PM, Paul Sajna wrote:
> December 4, 2025 at 9:17 AM, "Konrad Dybcio" <konrad.dybcio@....qualcomm.com mailto:konrad.dybcio@....qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:
> 
>> led-sources is parsed into a bitmap and written into REG_MODULE_EN,
>> this doesn't translate into anything that's userspace-visible
>>
>> That would instead be the case if you defined a pair of LEDs under
>> the device node (which is valid if there's two separate ones, such
>> as for some phones with a back and front LED flash)
>>
>> Konrad
>>
> 
> so it should be led-sources = <1 2> or something? Under a single node?

Eh of course what I said is wrong, it does indeed parse it, but in the
end it's a !!mask (if any enabled, enable the module)

but for your purposes, try "led-sources = <0>, <1>;" under a single node
that you have right now - the count also matters and it may just resolve
the presumably-overcurrent issue

Konrad