linux-kernel - Re: [PATCH v9 2/2] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <846a5cc1-fa0b-4952-ab40-852a07607eb7@oss.qualcomm.com>
Date: Fri, 5 Dec 2025 11:52:38 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Sudarshan Shetty <tessolveupstream@...il.com>, andersson@...nel.org,
        konradybcio@...nel.org
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 2/2] arm64: dts: qcom: talos-evk: Add support for
 QCS615 talos evk board

On 12/1/25 6:22 PM, Sudarshan Shetty wrote:
> Add the device tree for the QCS615-based Talos EVK platform. The
> platform is composed of a System-on-Module following the SMARC
> standard, and a Carrier Board.

[...]

> +	hdmi-out {

You must refer to existing nodes by &label references - let's call
this one hdmi_connector: hdmi-out {}

[...]

> +&i2c1 {
> +	clock-frequency = <400000>;
> +
> +	status = "okay";
> +
> +	bridge@3d {
> +		status = "disabled";
> +	};

Similarly here - hdmi_bridge: bridge@3d {}

> +
> +	bridge: bridge@2c {

lvds_bridge:

[...]

+
> +				sn65dsi84_in: endpoint {
> +				data-lanes = <0 1 2 3>;
> +				remote-endpoint = <&mdss_dsi0_out>;

The formatting fell apart a little here - please give it a touch-up

[...]

> +&tlmm {
> +	pcie_default_state: pcie-default-state {
> +		clkreq-pins {
> +			pins = "gpio90";
> +			function = "pcie_clk_req";
> +			drive-strength = <2>;
> +			bias-pull-up;
> +		};
> +
> +		perst-pins {
> +			pins = "gpio101";
> +			function = "gpio";
> +			drive-strength = <2>;
> +			bias-pull-down;

bias-disable - this pin is active-low

[...]

> +&i2c1 {
> +	clock-frequency = <400000>;
> +	status = "okay";
> +	bridge: bridge@3d {

This really needs a \n above
> +		compatible = "adi,adv7535";
> +		reg = <0x3d>;
> +		avdd-supply = <&vreg_v1p8_out>;
> +		dvdd-supply = <&vreg_v1p8_out>;
> +		pvdd-supply = <&vreg_v1p8_out>;
> +		a2vdd-supply = <&vreg_v1p8_out>;
> +		v3p3-supply = <&vreg_v3p3_out>;
> +		interrupts-extended = <&tlmm 26 IRQ_TYPE_LEVEL_LOW>;
> +		adi,dsi-lanes = <4>;
> +		ports {

And here

Konrad