linux-kernel - Re: [PATCH v8 12/22] wifi: nxpwifi: introduce command and event handling infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aTKajGqAIGVQwNnw@nxpwireless-Inspiron-14-Plus-7440>
Date: Fri, 5 Dec 2025 16:40:44 +0800
From: Jeff Chen <jeff.chen_1@....com>
To: Sascha Hauer <s.hauer@...gutronix.de>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	briannorris@...omium.org, johannes@...solutions.net,
	francesco@...cini.it, tsung-hsien.hsieh@....com
Subject: Re: [PATCH v8 12/22] wifi: nxpwifi: introduce command and event
 handling infrastructure

On Fri, Dec 05, 2025 at 08:11:12 AM +0100, Sascha Hauer wrote:
> Hi Jeff,
> 
> On Fri, Dec 05, 2025 at 02:55:35PM +0800, Jeff Chen wrote:
> > +
> > +	/* Check init command response */
> > +	if (adapter->hw_status == NXPWIFI_HW_STATUS_INITIALIZING) {
> > +		if (ret) {
> > +			nxpwifi_dbg(adapter, ERROR,
> > +				    "%s: cmd %#x failed during\t"
> > +				    "initialization\n", __func__, cmdresp_no);
> > +			nxpwifi_init_fw_complete(adapter);
> > +			return ret;
> > +		} else if (adapter->last_init_cmd == cmdresp_no) {
> > +			adapter->hw_status = NXPWIFI_HW_STATUS_INIT_DONE;
> > +		}
> > +	}
> 
> As said before, please drop this asynchronous initialization stuff.
> 
> A patch doing this for the mxiwiex driver is here:
> 
> https://lore.kernel.org/all/20241202-mwifiex-cleanup-1-v3-12-317a6ce0dd5b@pengutronix.de/
> 
> It will apply nearly as-is to the nxpwifi driver and it's much easier to
> do this before it hits mainline.
> 
> Sascha

Hi Sascha,
Thanks for the feedback and the reference patch. I’ll review it and try to apply these
changes in the next revision.