linux-kernel - Re: [PATCH next] drm/xe/vf: fix return type in vf_migration_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4827cdc3-014a-4085-bdf5-558c282cc9cf@intel.com>
Date: Fri, 5 Dec 2025 13:19:29 +0100
From: Michal Wajdeczko <michal.wajdeczko@...el.com>
To: Dan Carpenter <dan.carpenter@...aro.org>, Satyanarayana K V P
	<satyanarayana.k.v.p@...el.com>
CC: Thomas Hellström <thomas.hellstrom@...ux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@...el.com>, David Airlie <airlied@...il.com>,
	Simona Vetter <simona@...ll.ch>, <intel-xe@...ts.freedesktop.org>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH next] drm/xe/vf: fix return type in
 vf_migration_init_late()



On 12/5/2025 12:10 PM, Dan Carpenter wrote:
> The vf_migration_init_late() function is supposed to return zero on
> success and negative error codes on failure.  The error code
> eventually gets propagated back to the probe() function and returned.
> The problem is it's declared as type bool so it returns true on
> error.  Change it to type int instead.
> 
> Fixes: 2e2dab20dd66 ("drm/xe/vf: Enable VF migration only on supported GuC versions")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@...el.com>

> ---
>  drivers/gpu/drm/xe/xe_sriov_vf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_sriov_vf.c b/drivers/gpu/drm/xe/xe_sriov_vf.c
> index 86423a799d57..1b75405b8d02 100644
> --- a/drivers/gpu/drm/xe/xe_sriov_vf.c
> +++ b/drivers/gpu/drm/xe/xe_sriov_vf.c
> @@ -226,7 +226,7 @@ void xe_sriov_vf_init_early(struct xe_device *xe)
>  	vf_migration_init_early(xe);
>  }
>  
> -static bool vf_migration_init_late(struct xe_device *xe)
> +static int vf_migration_init_late(struct xe_device *xe)
>  {
>  	struct xe_gt *gt = xe_root_mmio_gt(xe);
>  	struct xe_uc_fw_version guc_version;