linux-kernel - Re: [PATCH v2 2/3] usb: dwc3: imx8mp: rename dwc3 to dwc3_pdev in struct dwc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aTL2ScHJNTjj9AU3@lizhi-Precision-Tower-5810>
Date: Fri, 5 Dec 2025 10:12:09 -0500
From: Frank Li <Frank.li@....com>
To: Xu Yang <xu.yang_2@....com>
Cc: Thinh.Nguyen@...opsys.com, gregkh@...uxfoundation.org,
	shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
	festevam@...il.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, jun.li@....com
Subject: Re: [PATCH v2 2/3] usb: dwc3: imx8mp: rename dwc3 to dwc3_pdev in
 struct dwc3_imx8mp

On Fri, Dec 05, 2025 at 11:29:41AM +0800, Xu Yang wrote:
> It's confuse to let "dwc3" represent a platform_device, because "dwc3"
> may also represent a dwc3 core structure. Rename it for better
> distinction.
>
> Signed-off-by: Xu Yang <xu.yang_2@....com>
>

Reviewed-by: Frank Li <Frank.Li@....com>

> ---
> Changes in v2:
>  - new patch
> ---
>  drivers/usb/dwc3/dwc3-imx8mp.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-imx8mp.c
> index 050da327f785..8bece4baecbf 100644
> --- a/drivers/usb/dwc3/dwc3-imx8mp.c
> +++ b/drivers/usb/dwc3/dwc3-imx8mp.c
> @@ -51,7 +51,7 @@
>
>  struct dwc3_imx8mp {
>  	struct device			*dev;
> -	struct platform_device		*dwc3;
> +	struct platform_device		*dwc3_pdev;
>  	void __iomem			*hsio_blk_base;
>  	void __iomem			*glue_base;
>  	struct clk			*hsio_clk;
> @@ -100,7 +100,7 @@ static void imx8mp_configure_glue(struct dwc3_imx8mp *dwc3_imx)
>  static void dwc3_imx8mp_wakeup_enable(struct dwc3_imx8mp *dwc3_imx,
>  				      pm_message_t msg)
>  {
> -	struct dwc3	*dwc3 = platform_get_drvdata(dwc3_imx->dwc3);
> +	struct dwc3	*dwc3 = platform_get_drvdata(dwc3_imx->dwc3_pdev);
>  	u32		val;
>
>  	if (!dwc3)
> @@ -142,7 +142,7 @@ static const struct software_node dwc3_imx8mp_swnode = {
>  static irqreturn_t dwc3_imx8mp_interrupt(int irq, void *_dwc3_imx)
>  {
>  	struct dwc3_imx8mp	*dwc3_imx = _dwc3_imx;
> -	struct dwc3		*dwc = platform_get_drvdata(dwc3_imx->dwc3);
> +	struct dwc3		*dwc = platform_get_drvdata(dwc3_imx->dwc3_pdev);
>
>  	if (!dwc3_imx->pm_suspended)
>  		return IRQ_HANDLED;
> @@ -233,8 +233,8 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev)
>  		goto remove_swnode;
>  	}
>
> -	dwc3_imx->dwc3 = of_find_device_by_node(dwc3_np);
> -	if (!dwc3_imx->dwc3) {
> +	dwc3_imx->dwc3_pdev = of_find_device_by_node(dwc3_np);
> +	if (!dwc3_imx->dwc3_pdev) {
>  		dev_err(dev, "failed to get dwc3 platform device\n");
>  		err = -ENODEV;
>  		goto depopulate;
> @@ -253,7 +253,7 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev)
>  	return 0;
>
>  put_dwc3:
> -	put_device(&dwc3_imx->dwc3->dev);
> +	put_device(&dwc3_imx->dwc3_pdev->dev);
>  depopulate:
>  	of_platform_depopulate(dev);
>  remove_swnode:
> @@ -270,7 +270,7 @@ static void dwc3_imx8mp_remove(struct platform_device *pdev)
>  	struct dwc3_imx8mp *dwc3_imx = platform_get_drvdata(pdev);
>  	struct device *dev = &pdev->dev;
>
> -	put_device(&dwc3_imx->dwc3->dev);
> +	put_device(&dwc3_imx->dwc3_pdev->dev);
>
>  	pm_runtime_get_sync(dev);
>  	of_platform_depopulate(dev);
> @@ -296,7 +296,7 @@ static int dwc3_imx8mp_suspend(struct dwc3_imx8mp *dwc3_imx, pm_message_t msg)
>
>  static int dwc3_imx8mp_resume(struct dwc3_imx8mp *dwc3_imx, pm_message_t msg)
>  {
> -	struct dwc3	*dwc = platform_get_drvdata(dwc3_imx->dwc3);
> +	struct dwc3	*dwc = platform_get_drvdata(dwc3_imx->dwc3_pdev);
>  	int ret = 0;
>
>  	if (!dwc3_imx->pm_suspended)
> --
> 2.34.1
>